Enabling spotless for all modules #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VachaShah
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda and
saratvemulapalli
as code owners
dblock
previously approved these changes
Oct 4, 2023
Thank you @dblock! I will add all files for spotless changes in this PR divided by commits. |
VachaShah
force-pushed
the
checkstyle-to-spotless-1
branch
from
62c231a
to
56341be
Compare
VachaShah
changed the title
dblock
previously approved these changes
Oct 5, 2023
Haha, weird javadoc.io is not reachable since many days. Let me see if we can replace the link. |
VachaShah
force-pushed
the
checkstyle-to-spotless-1
branch
from
ef0a71f
to
bd268b1
Compare
|
@dblock I added the javadoc.io link in excludes in the latest commit till it is fixed. I will create an issue to track this. |
dblock
previously approved these changes
Oct 5, 2023
|
Let's merge this before it hits a conflict? @Bukhtawar @saratvemulapalli ? |
saratvemulapalli
previously approved these changes
Oct 9, 2023
|
@VachaShah couple of conflicts :/ |
Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
…asks modules Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
VachaShah
dismissed stale reviews from saratvemulapalli and dblock
via
bcc201b
VachaShah
force-pushed
the
checkstyle-to-spotless-1
branch
from
bd268b1
to
bcc201b
Compare
|
@dblock @saratvemulapalli Review again please? I fixed the merge conflicts and also removed the exclusion of the javadoc.io link since it is fixed now. |
saratvemulapalli
approved these changes
Oct 9, 2023
dblock
approved these changes
Oct 9, 2023
|
Do we backport this? |
Yeah I will backport this PR and the previous PR #648 manually to 2.x since there will be a lot of conflicts. |
VachaShah
added a commit
to VachaShah/opensearch-java
that referenced
this pull request
Oct 11, 2023
* Enabling spotless for _types module Signed-off-by: Vacha Shah <vachshah@amazon.com> * Enabling spotless for cat module Signed-off-by: Vacha Shah <vachshah@amazon.com> * Enabling spotless for cluster module Signed-off-by: Vacha Shah <vachshah@amazon.com> * Enabling spotless for core module Signed-off-by: Vacha Shah <vachshah@amazon.com> * Enabling spotless for dangling_indices, features, ingest, shutdown, tasks modules Signed-off-by: Vacha Shah <vachshah@amazon.com> * Enabling spotless for indices module Signed-off-by: Vacha Shah <vachshah@amazon.com> * Enabling spotless for nodes and snapshot modules Signed-off-by: Vacha Shah <vachshah@amazon.com> * Enabling spotless for remaining opensearch module Signed-off-by: Vacha Shah <vachshah@amazon.com> * Enabling spotless for rest of the code including tests Signed-off-by: Vacha Shah <vachshah@amazon.com> * Fixing spotless from merge conflicts Signed-off-by: Vacha Shah <vachshah@amazon.com> --------- Signed-off-by: Vacha Shah <vachshah@amazon.com>
dblock
pushed a commit
that referenced
this pull request
Oct 12, 2023
…661) * Migrating from checkstyle to spotless for formatting (#648) * Adding spotless for checking and fixing formatting and removing checkstyle Signed-off-by: Vacha Shah <vachshah@amazon.com> * Making build task depend on spotlessJavaCheck Signed-off-by: Vacha Shah <vachshah@amazon.com> * Removing resources and documentation related to checkstyle Signed-off-by: Vacha Shah <vachshah@amazon.com> * Running spotless for json, transport and util folders Signed-off-by: Vacha Shah <vachshah@amazon.com> * Running spotless for samples Signed-off-by: Vacha Shah <vachshah@amazon.com> * Removing commented code Signed-off-by: Vacha Shah <vachshah@amazon.com> --------- Signed-off-by: Vacha Shah <vachshah@amazon.com> * Fixing merge conflicts and build Signed-off-by: Vacha Shah <vachshah@amazon.com> * Enabling spotless for all modules from PR 651 Signed-off-by: Vacha Shah <vachshah@amazon.com> * Applying spotless to all the remaining files Signed-off-by: Vacha Shah <vachshah@amazon.com> --------- Signed-off-by: Vacha Shah <vachshah@amazon.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enabled spotless for all modules in the repo. Did it module by module per commit by running
./gradlew spotlessApplyfor each.Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.