Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PutTemplateRequest deserialization #723

Merged
merged 6 commits into from
Nov 18, 2023

Conversation

Bfindlay
Copy link
Contributor

@Bfindlay Bfindlay commented Nov 13, 2023

Description

Link to issue 417

This PR adds in the missing deserialization steps to the PutTemplateRequest _DESERIALIZER which would result in the error
Missing required property 'PutTemplateRequest.name' if you tried to deserialize a request object.

Issues Resolved

#417

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: bfindlay <bfindlay@acm.org>
Signed-off-by: bfindlay <bfindlay@acm.org>
Signed-off-by: bfindlay <bfindlay@acm.org>
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I made some nitpicky comments.

Signed-off-by: bfindlay <bfindlay@acm.org>
@Bfindlay Bfindlay requested a review from dblock November 13, 2023 23:12
Signed-off-by: bfindlay <bfindlay@acm.org>
Signed-off-by: bfindlay <bfindlay@acm.org>
@Bfindlay
Copy link
Contributor Author

@dblock Comments addressed 👍

@dblock dblock merged commit 3ec3cae into opensearch-project:main Nov 18, 2023
44 checks passed
@reta reta mentioned this pull request Feb 6, 2024
@VachaShah VachaShah added the backport 2.x Backport to 2.x branch label Feb 7, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-723-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3ec3cae6a0c1723c7e86acf8f967750ef806d4c7
# Push it to GitHub
git push --set-upstream origin backport/backport-723-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-723-to-2.x.

VachaShah pushed a commit to VachaShah/opensearch-java that referenced this pull request Feb 7, 2024
* fix PutTemplateRequest deserialization

Signed-off-by: bfindlay <bfindlay@acm.org>

* update changelog

Signed-off-by: bfindlay <bfindlay@acm.org>

* fix changelog PR number

Signed-off-by: bfindlay <bfindlay@acm.org>

* update for pr review

Signed-off-by: bfindlay <bfindlay@acm.org>

* update unit test for pr

Signed-off-by: bfindlay <bfindlay@acm.org>

* apply spotless check

Signed-off-by: bfindlay <bfindlay@acm.org>

---------

Signed-off-by: bfindlay <bfindlay@acm.org>
VachaShah pushed a commit to VachaShah/opensearch-java that referenced this pull request Feb 8, 2024
* fix PutTemplateRequest deserialization

Signed-off-by: bfindlay <bfindlay@acm.org>

* update changelog

Signed-off-by: bfindlay <bfindlay@acm.org>

* fix changelog PR number

Signed-off-by: bfindlay <bfindlay@acm.org>

* update for pr review

Signed-off-by: bfindlay <bfindlay@acm.org>

* update unit test for pr

Signed-off-by: bfindlay <bfindlay@acm.org>

* apply spotless check

Signed-off-by: bfindlay <bfindlay@acm.org>

---------

Signed-off-by: bfindlay <bfindlay@acm.org>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
reta pushed a commit that referenced this pull request Feb 8, 2024
* fix PutTemplateRequest deserialization



* update changelog



* fix changelog PR number



* update for pr review



* update unit test for pr



* apply spotless check



---------

Signed-off-by: bfindlay <bfindlay@acm.org>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
Co-authored-by: Brett Findlay <brett@dawnpatroltv.com>
@Bfindlay
Copy link
Contributor Author

Hi @reta @VachaShah I see the backport job failed, does this mean that the fix was not released?

@reta
Copy link
Collaborator

reta commented Feb 11, 2024

Hi @reta @VachaShah I see the backport job failed, does this mean that the fix was not released?

Sadly yeah, we missed it but @VachaShah did manual backport a few days ago. I think we could make another release this week, sorry about that @Bfindlay

@Bfindlay
Copy link
Contributor Author

@reta Thanks for the update, would be great if you can keep me in the loop on the release as this is a blocker for us.
Thanks!

@VachaShah
Copy link
Collaborator

@BrendonFaleiro BrendonFaleiro mentioned this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants