-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Rewrite this client in TypeScript #269
Comments
To assure that the rewrite does not affect existing users of the JS client, while capturing all features of this JS client in the TS client, I propose the following steps:
@dblock @AMoo-Miki I'd love to have your input on this. |
@timursaurus has already started the rewrote effort on his own repo. It gives us an idea of what the final product would look like. @timursaurus can also port a lot of his work from that repo into this, while other contributors can also make PRs to contribute to this effort. |
@nhtruong This LGTM. I'd call the branch |
Hello is someone currently working on this? It looks like there but I saw there is no one assigned to it. |
@RealZacharyFowler you're absolutely welcomed to chip in. No one has made any PR just yet. Though do note that this is a rewrite of the entire client. We're not just doing a 1-to-1 translation to TS. We're looking to make big improvements to get rid of glaring issues in the current JS clients WHILE maintaining backward compatibility (meaning users should not have to make next to no major changes on their applications when switching over to our new TS client). This means we will have to thoroughly study the current JS client to be able to rewrite it in TS. |
Is your feature request related to a problem?
Coming from #266 (comment), TypeScript bindings are maintained by hand. Development in pure JS is slower, potentially more error prone.
What solution would you like?
Rewrite the client in TypeScript, get rid of pure JS code.
The text was updated successfully, but these errors were encountered: