Add missing memory circuit breaker options

[robdasilva]

Description

Add missing memoryCircuitBreaker option in Transport.d.ts.

The discussion in opensearch-project/documentation-website#823 revealed that this option appeared to be missing: opensearch-project/documentation-website#823 (comment)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[kavilla]

Thank you so much for adding this

[ananzh]

nice. thanks a lot

[dblock]

Looks like a test failed?

We need tests for this, don't we?

[robdasilva]

@dblock The integration test appears to have failed due to no tests being found. So there seem to exist no tests yet for the client helpers. As this PR merely adds an option to the type declarations (...d.ts) that already exists in code, the changes in this PR should ink y understanding not have the potential to break existing behavior. Do you have any concerns?

[dblock]

Looks like tests are failing on main, I opened #268 (someone should please take care of this).

We could merge this PR as is, it doesn't break anything existing, but I would expect any new code (this new option added) to be exercised in tests so that we don't break it in the future.

[robdasilva]

I would expect any new code (this new option added) to be exercised in tests so that we don't break it in the future.

@dblock Absolutely, I agree. What I mentioned above though, is that this PR does not add the option. It was there before already. This PR only adds it to the type declarations.

How would the types be tested to contain all options actually available in the code?

[dblock]

I see. I think we should rewrite this client in TypeScript :)

How do we know if other options are not missing?

[dblock]

I merged this, thanks.

[robdasilva]

How do we know if other options are not missing?

@dblock Rewriting in TypeScript would be one option. But other than that it's a tricky question. I'd be curios to know myself.

The existing TypeScript types could actually be used in the JS code using JSDoc comments, but that would only help with code completion. Not necessarily with ensuring there is no mismatch between the code and manually written TS declarations.

Using JSDoc to define the parameters and generating TS types from that might be an option. But I have little experience with that tbh.

[dblock]

I opened #269 to gather input on whether anyone feels strongly about rewriting this client in TypeScript, or wants to take a stab at it!

[opensearch-trigger-bot]

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-266-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e07a521910103831947673f95cb5a1db3241446b
# Push it to GitHub
git push --set-upstream origin backport/backport-266-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-266-to-1.x.