Fix serverless signing with body #367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
harshavamsi
force-pushed
the
serverlessSigV4
branch
from
06ecee3
to
9be6fe5
Compare
dblock
reviewed
Jan 21, 2023
| request.headers['X-Amz-Content-Sha256'] = hash(request.body || '', 'hex'); | ||
| request.extraHeadersToIgnore = { | ||
| 'content-length': true, | ||
| }; |
There was a problem hiding this comment.
Was this the issue? Content-length needed to be included?
https://github.com/opensearch-project/opensearch-js/pull/366/files
There was a problem hiding this comment.
No, looks like that PR is not including x-amz-content-sha256 in the signing process. It signs the request first and then computes the hash in the header. Weird, I tried this but it did not work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harsha Vamsi Kalluri harshavamsi096@gmail.com
Description
Proof of concept with SigV4 signing for serverless. This is still a work in progress. I can't seem to understand why this does not work. I compute the body hash and set the
x-amz-content-sha256header and use that to sign the request, but there is a mismatch in the signature.Issues Resolved
Closes #356
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.