Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow fields in BulkOperation to be optional #378

Merged
merged 3 commits into from
Feb 8, 2023
Merged

Allow fields in BulkOperation to be optional #378

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ac7d58
Allow fields in BulkOperation to be optional
camerondurham Feb 3, 2023
6305e7d
Update CHANGELOG.md
camerondurham Feb 6, 2023
002cf8e
Re-add linebreak
camerondurham Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
### Dependencies
### Changed
- Remove test artifacts from gh_pages workflow ([#335](https://github.com/opensearch-project/opensearch-js/issues/335))
- Make fields in `BulkOperation` optional to match OpenSearch Bulk API requirements ([#378](https://github.com/opensearch-project/opensearch-js/pull/378))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would re-add an empty line here ;)

### Deprecated
### Removed
### Fixed
Expand All @@ -56,4 +57,4 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Fix mutability of connection headers ([#291](https://github.com/opensearch-project/opensearch-js/issues/291))

[2.1]: https://github.com/opensearch-project/opensearch-js/releases/tag/2.1.0
[Unreleased]: https://github.com/opensearch-project/opensearch-js/compare/2.1...HEAD
[Unreleased]: https://github.com/opensearch-project/opensearch-js/compare/2.1...HEAD
12 changes: 6 additions & 6 deletions api/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ export interface BulkIndexOperation extends BulkOperation { }
export interface BulkIndexResponseItem extends BulkResponseItemBase { }

export interface BulkOperation {
_id: Id;
_index: IndexName;
retry_on_conflict: integer;
routing: Routing;
version: VersionNumber;
version_type: VersionType;
_id?: Id;
_index?: IndexName;
retry_on_conflict?: integer;
routing?: Routing;
version?: VersionNumber;
version_type?: VersionType;
}

export interface BulkOperationContainer {
Expand Down