Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

?v -> ?v=true to workaround the sigv4 bug #1031

Merged

Conversation

mikaylathompson
Copy link
Collaborator

@mikaylathompson mikaylathompson commented Sep 30, 2024

Description

There's a bug in our sigv4 dependency for requests that breaks when a url has a query param with no value. So ?v fails but ?v=true succeeds.

Issues Resolved

https://opensearch.atlassian.net/browse/MIGRATIONS-2023

Testing

Manual

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.31%. Comparing base (b26db7f) to head (574d110).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1031      +/-   ##
============================================
- Coverage     80.39%   80.31%   -0.08%     
+ Complexity     2729     2726       -3     
============================================
  Files           366      366              
  Lines         13617    13617              
  Branches        942      942              
============================================
- Hits          10947    10937      -10     
- Misses         2095     2106      +11     
+ Partials        575      574       -1     
Flag Coverage Δ
gradle-test 78.30% <ø> (-0.09%) ⬇️
python-test 90.11% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good work around, thanks for creating the issue on the source library [1]

@mikaylathompson mikaylathompson merged commit 10fa760 into opensearch-project:main Sep 30, 2024
14 checks passed
@mikaylathompson mikaylathompson deleted the sigv4-bug-workaround branch September 30, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants