-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continue to evaulate / migrate after failures #1037
Continue to evaulate / migrate after failures #1037
Conversation
Updates the behavoir of the metadata processing for templates and indexes to collect all the results and then return failure details after all items have been processed. Signed-off-by: Peter Nied <peternied@hotmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1037 +/- ##
============================================
- Coverage 80.54% 80.17% -0.38%
- Complexity 2736 2745 +9
============================================
Files 365 367 +2
Lines 13614 13743 +129
Branches 941 949 +8
============================================
+ Hits 10966 11018 +52
- Misses 2068 2149 +81
+ Partials 580 576 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RFS/src/main/java/org/opensearch/migrations/metadata/CreationResult.java
Show resolved
Hide resolved
MetadataMigration/src/main/java/org/opensearch/migrations/cli/Items.java
Show resolved
Hide resolved
RFS/src/main/java/org/opensearch/migrations/bulkload/version_os_2_11/IndexCreator_OS_2_11.java
Show resolved
Hide resolved
RFS/src/main/java/org/opensearch/migrations/metadata/CreationResult.java
Outdated
Show resolved
Hide resolved
RFS/src/main/java/org/opensearch/migrations/metadata/GlobalMetadataCreatorResults.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Peter Nied <peternied@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup, i'm good for merging once the isolatedTests are fixed
Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
This reverts commit bfafa20. Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
6ad40bf
to
c0e242d
Compare
Description
Updates the behavior of the metadata processing for templates and indexes to collect all the results and then return failure details after all items have been processed. When items are not created they will appear in the output with a reason and exception if needed be. Here is the output from an updated evaulate test case where the index
already_exists
was already on the target cluster and won't be created.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.