Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply dependency overrides to all dependency types #1040

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented Oct 1, 2024

Description

Apply dependency overrides to all dependency types

  • Category: Fixes dependency versions across all compile types
  • Why these changes are required? Protobuf wasn't using a consistent version
  • What is the old behavior before changes and new behavior after changes? Annotation processing depended on protobuf 2.19 instead of current 2.25

Issues Resolved

[List any issues this PR will resolve]

Is this a backport? If so, please add backport PR # and/or commits #

Testing

GHA, verified dependency versions with ./gradlew <task>:dependencies

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.53%. Comparing base (f28e131) to head (a8c231b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1040      +/-   ##
============================================
- Coverage     80.56%   80.53%   -0.04%     
+ Complexity     2736     2734       -2     
============================================
  Files           365      365              
  Lines         13611    13611              
  Branches        941      941              
============================================
- Hits          10966    10961       -5     
- Misses         2067     2068       +1     
- Partials        578      582       +4     
Flag Coverage Δ
gradle-test 78.56% <ø> (-0.05%) ⬇️
python-test 90.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Andre Kurait <akurait@amazon.com>
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, thanks for getting this cleaned up for the whole codebase.

@@ -13,6 +13,20 @@ allprojects {
}
}

subprojects { subproject ->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@peternied peternied merged commit 5015220 into opensearch-project:main Oct 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants