-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a script to determine the AWS resources used #1050
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To help customers determine what resources are used by the Migration Assistant when deployed adding a shell script that can be used on the bootstrap machine to identify what there deployment will require based on the synthesized stacks. Example output: ```shell ./aws-feature-usage.sh default Synthesizing all stacks... Synthesizing stack: networkStack-default Synthesizing stack: migrationInfraStack Synthesizing stack: reindexFromSnapshotStack Synthesizing stack: migration-console Finding resource usage from synthesized stacks... ----------------------------------- IAM Policy Actions: cloudwatch:GetMetricData cloudwatch:ListMetrics ec2:DescribeRouteTables ec2:DescribeSubnets ecr:BatchCheckLayerAvailability ... ----------------------------------- Resources Types: AWS::CDK::Metadata AWS::EC2::InternetGateway AWS::EC2::Route AWS::EC2::RouteTable AWS::EC2::SecurityGroup ... ``` Signed-off-by: Peter Nied <peternied@hotmail.com>
peternied
requested review from
AndreKurait,
chelma,
gregschohn,
lewijacn,
mikaylathompson and
sumobrian
as code owners
October 3, 2024 20:11
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1050 +/- ##
============================================
+ Coverage 80.57% 80.59% +0.02%
Complexity 2736 2736
============================================
Files 365 365
Lines 13611 13653 +42
Branches 941 941
============================================
+ Hits 10967 11004 +37
- Misses 2067 2069 +2
- Partials 577 580 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lewijacn
reviewed
Oct 8, 2024
deployment/cdk/opensearch-service-migration/aws-feature-usage.sh
Outdated
Show resolved
Hide resolved
peternied
force-pushed
the
aws-features
branch
from
October 9, 2024 18:35
84c4090
to
e1e262b
Compare
…ploy script Signed-off-by: Peter Nied <peternied@hotmail.com>
peternied
force-pushed
the
aws-features
branch
from
October 9, 2024 18:38
e1e262b
to
d61b416
Compare
peternied
commented
Oct 9, 2024
lewijacn
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To help customers determine what resources are used by the Migration Assistant when deployed adding a shell script that can be used on the bootstrap machine to identify what there deployment will require based on the synthesized stacks.
Example output:
Testing
Ran locally, manually
Check List
New functionality includes testingAll tests pass, including unit test, integration test and doctestNew functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.