Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update root readme adding key features, repo structure details, user uide reference, jira reference, details for repo clarity. #1066

Merged
merged 7 commits into from
Oct 16, 2024

Conversation

sumobrian
Copy link
Collaborator

@sumobrian sumobrian commented Oct 12, 2024

Description

Objective: Revise the root README.md file of the opensearch-migrations project to provide a comprehensive overview and detailed documentation, enhancing clarity and usability for users and contributors. Provide references to other READMEs in the repo.

Tasks Completed:

  • Rename the Title.
  • Add a Detailed Table of Contents.
  • Update the Overview Section.
  • Identify Key Features.
  • Update Supported Versions and Platforms.
  • Add Issue Tracking Information.
  • Detail the Project Structure.
  • Include a reference to User Guide.
  • Add Getting Started Instructions.
  • Reorignize the Development Section.
  • Update Contributing Guidelines.
  • Detail Publishing Instructions
  • Add Acknowledgments.
  • Remove Release Section.
  • Correct Spelling and Grammar Errors.
  • Improve Formatting and Consistency.
  • Enhance Readability.
  • Verify External References.

Issues Resolved

JIRA MIGRATIONS-2081

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Verified links do not return 404s and that targets work as expected. The gradle targets need to be updated. Ideally gradlew build would build the complete solution. I opened a bug to make this change.

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…guide reference, jira reference, details for repo clarity.

Signed-off-by: Brian Presley <bjpres@amazon.com>
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.19%. Comparing base (0b08287) to head (564ea9c).
Report is 25 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1066      +/-   ##
============================================
+ Coverage     80.16%   80.19%   +0.02%     
- Complexity     2744     2863     +119     
============================================
  Files           367      383      +16     
  Lines         13743    14333     +590     
  Branches        949      988      +39     
============================================
+ Hits          11017    11494     +477     
- Misses         2149     2245      +96     
- Partials        577      594      +17     
Flag Coverage Δ
gradle-test 78.21% <ø> (+0.13%) ⬆️
python-test 90.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ks, CI/CD process, and deployment prerequisites in README.

Signed-off-by: Brian Presley <bjpres@amazon.com>
Signed-off-by: Brian Presley <bjpres@amazon.com>
Signed-off-by: Brian Presley <bjpres@amazon.com>
README.md Outdated Show resolved Hide resolved
@sumobrian sumobrian self-assigned this Oct 14, 2024
@sumobrian sumobrian marked this pull request as ready for review October 14, 2024 15:31
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
…ded to DEVELOPER_GUIDE.md

Signed-off-by: Brian Presley <bjpres@amazon.com>
Signed-off-by: Brian Presley <bjpres@amazon.com>
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a more detailed read of the readme, minor comments. Looks good to merge when you are ready, thanks!

- **Upgrade and Migration Support**: Provides tools for migrating between different versions of Elasticsearch and OpenSearch.
- **[Metadata Migration](MetadataMigration/README.md)**: Migrate essential cluster components such as configuration, settings, templates, and aliases.
- **Multi-Version Upgrade**: Easily migrate across major versions (e.g., from Elasticsearch 6.8 to OpenSearch 2.15), skipping intermediate upgrades and reducing time and risk.
- **Downgrade Support**: Downgrade to an earlier version if needed (e.g., from Elasticsearch 7.17 to 7.10.2).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't any workflows that allow for downgrades. Is this a more idealized version of what the toolset can support or something that we want to promote as possible in the tool today?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend removing this bullet until we've got more concrete support and validation in place.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you concerned about this specific migration path? This solution is recommended for users who want to move from versions greater than 7.10.2 back to 7.10.2.

[Docker Solution](TrafficCapture/dockerSolution/README.md).
- **Flexible Deployment Options**:
- **[AWS Deployment](https://aws.amazon.com/solutions/implementations/migration-assistant-for-amazon-opensearch-service/)**: Fully automated deployment to AWS.
- **[Local Docker Deployment](/TrafficCapture/dockerSolution/README.md)**: Run the solution locally in a container for testing and development.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local docker doesn't work in a number of scenarios, I'd recommend pulling it from this list. By following the developer guide this is technically possible, but we haven't made an effort to make sure this is a good user experience.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this may not be consistent across the solution, it’s crucial to support it. This approach enables rapid development and allows others to test the solution without fully committing to using it in the cloud. It also keeps the solution flexible for broader community adoption. We encourage users to explore these options and open issues if they encounter any challenges. This feedback not only helps improve the solution but also enhances the onboarding experience for everyone.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does work for a number of scenarios and we have at least one engagement that leveraged this, especially in their early development. We should be striving to get a solution that any student or developer could stand up and test anywhere.

Instead of pulling this out, we should open up issues for where this doesn't work and we can track them. My guess is that K8s work can subsume all of this, but we'll run into this case in the future if we don't hold all of our projects to the same standard of building for at least two deployment environments. This documentation is the only thing that we have to uphold that contract.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: Brian Presley <bjpres@amazon.com>
@sumobrian sumobrian merged commit 8e6d65f into opensearch-project:main Oct 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants