-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace requests-auth-aws-sigv4 with boto3 signing #1077
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1077 +/- ##
============================================
+ Coverage 80.19% 80.21% +0.02%
- Complexity 2863 2866 +3
============================================
Files 383 383
Lines 14333 14358 +25
Branches 988 988
============================================
+ Hits 11494 11517 +23
- Misses 2245 2247 +2
Partials 594 594
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6eb32a8
to
983ea25
Compare
a7a3586
to
590f8a2
Compare
Signed-off-by: Andre Kurait <akurait@amazon.com>
590f8a2
to
1497c8b
Compare
Signed-off-by: Andre Kurait <akurait@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a fantastic test. Thanks for making it so comprehensive. I'm impressed how surgical this change is overall.
# requests to AWS services using SigV4. | ||
|
||
|
||
class SigV4AuthPlugin(requests.auth.AuthBase): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This integrates it so elegantly! I like it!
Description
Replace requests-auth-aws-sigv4 with boto3 signing
?v
or*
in urlIssues Resolved
MIGRATIONS-2099
Is this a backport? If so, please add backport PR # and/or commits #
Testing
Added unit tests
Tested locally against an aws cluster with sigv4
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.