[Bug] Cleanup deployment fix for paginated list stacks #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
lewijacn
requested review from
AndreKurait,
chelma,
gregschohn,
mikaylathompson,
peternied and
sumobrian
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1111 +/- ##
============================================
- Coverage 80.55% 78.84% -1.71%
Complexity 2930 2930
============================================
Files 390 358 -32
Lines 14462 12310 -2152
Branches 998 998
============================================
- Hits 11650 9706 -1944
+ Misses 2209 2001 -208
Partials 603 603
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
peternied
approved these changes
Oct 30, 2024
| @@ -139,7 +139,7 @@ def delete_stacks_for_environment(stage_name: str): | |||
| next_stack_names = [stack['StackName'] for stack in next_list_stacks_response['StackSummaries'] | |||
| if stack['StackStatus'] not in CFN_INITIAL_STATUS_SKIP] | |||
| stack_names.extend(next_stack_names) | |||
| list_stacks_response.get("NextToken", None) | |||
| next_token = next_list_stacks_response.get("NextToken", None) | |||
There was a problem hiding this comment.
Nit: switch to do {} while pattern to prevent this kind of bug in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug fix for cleanup deployment to properly handle CFN list stacks giving paginated response
Issues Resolved
None created
Is this a backport? If so, please add backport PR # and/or commits #
Testing
Local testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.