Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test ES 6.8 to use es-oss image #1114

Merged

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented Nov 4, 2024

Description

I encountered startup issues running the ES 6.8 image on apple silicon due to x-pack-ml.

Fixed encountered metadata issue when only a single template exists in the cluster.

  • Category: Bug Fix
  • Why these changes are required? We shouldn't depend on 6.8 x-pack in unit tests
  • What is the old behavior before changes and new behavior after changes? Encountered failure org.elasticsearch.bootstrap.StartupException: org.elasticsearch.bootstrap.BootstrapException: java.io.IOException: Cannot run program "/usr/share/elasticsearch/modules/x-pack-ml/platform/linux-x86_64/bin/controller": error=0, Failed to exec spawn helper: pid: 111, exit value: 1 at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:163) exiting container in test

Issues Resolved

MIGRATIONS-2202

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Ran locally on M3 Pro

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andre Kurait <akurait@amazon.com>
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.53%. Comparing base (dc326f0) to head (f6c8663).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
...bulkload/version_universal/RemoteReaderClient.java 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1114      +/-   ##
============================================
- Coverage     80.55%   80.53%   -0.03%     
+ Complexity     2930     2929       -1     
============================================
  Files           390      390              
  Lines         14462    14464       +2     
  Branches        998      999       +1     
============================================
- Hits          11650    11648       -2     
- Misses         2209     2211       +2     
- Partials        603      605       +2     
Flag Coverage Δ
gradle-test 78.60% <60.00%> (-0.03%) ⬇️
python-test 90.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreKurait AndreKurait marked this pull request as ready for review November 4, 2024 16:51
@AndreKurait AndreKurait force-pushed the isolatedTestFixAppleSilicon branch 6 times, most recently from 068bbfa to a9dc3ff Compare November 5, 2024 14:31
Signed-off-by: Andre Kurait <akurait@amazon.com>
@AndreKurait AndreKurait force-pushed the isolatedTestFixAppleSilicon branch from a9dc3ff to f6c8663 Compare November 5, 2024 14:34
@AndreKurait AndreKurait merged commit e78d172 into opensearch-project:main Nov 5, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants