Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Netty to 4.1.100 #408

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

gregschohn
Copy link
Collaborator

@gregschohn gregschohn commented Nov 11, 2023

Description

  • Category Security fix

Issues Resolved

#343

Testing

./gradlew clean build :trafficReplayer:longTest
./gradlew :dockerSolution:composeUp followed by an OSB run that showed 1K docs in 10 indices on the target (as expected).

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #408 (d8e7c41) into main (eeededc) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head d8e7c41 differs from pull request most recent head 29d1ea4. Consider uploading reports for the commit 29d1ea4 to get more accurate results

@@             Coverage Diff              @@
##               main     #408      +/-   ##
============================================
- Coverage     62.80%   62.78%   -0.02%     
  Complexity      862      862              
============================================
  Files            99       99              
  Lines          4339     4345       +6     
  Branches        404      405       +1     
============================================
+ Hits           2725     2728       +3     
- Misses         1344     1347       +3     
  Partials        270      270              
Flag Coverage Δ
unittests 62.78% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@gregschohn gregschohn changed the base branch from main to ReusedReplayerClientConnections November 13, 2023 04:16
@gregschohn gregschohn changed the base branch from ReusedReplayerClientConnections to main November 13, 2023 04:16
@gregschohn gregschohn merged commit d52f47c into opensearch-project:main Nov 13, 2023
5 checks passed
@gregschohn gregschohn deleted the Netty4_1_100 branch November 30, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants