Skip to content

Commit

Permalink
Address PR feedback by @MaxKsyunz.
Browse files Browse the repository at this point in the history
Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
  • Loading branch information
Yury-Fridlyand committed Aug 25, 2022
1 parent 0d58b5b commit 571669b
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
fail-fast: false
matrix:
# 1.0.1 is skipped because it doesn't have a tag in OpenSearch repo, we can't check out to compile plugins
version: [2.0.0, 1.3.1, 1.3.0, 1.2.4, 1.2.3, 1.2.2, 1.2.1, 1.2.0, 1.1.0, 1.0.0]
version: [2.2.0, 2.1.0, 2.0.0, 1.3.1, 1.3.0, 1.2.4, 1.2.3, 1.2.2, 1.2.1, 1.2.0, 1.1.0, 1.0.0]

steps:
# Due to https://github.com/opensearch-project/project-website/issues/737
Expand Down
2 changes: 1 addition & 1 deletion src/ApiGenerator/RestSpecification/Core/get_script.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
},
"cluster_manager_timeout":{
"type":"time",
"description":"Explicit operation timeout for connection to cluster_manager_timeout node"
"description":"Explicit operation timeout for connection to cluster_manager node"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/OpenSearch.Client.JsonNetSerializer/README.md
Original file line number Diff line number Diff line change
@@ -1 +1 @@
An auxiliary tool used by `OpenSearch.Client` to serialize and deserialize data.
An auxiliary library used by `OpenSearch.Client` to serialize and deserialize data.
12 changes: 6 additions & 6 deletions src/OpenSearch.Client/Descriptors.NoNamespace.cs
Original file line number Diff line number Diff line change
Expand Up @@ -440,10 +440,10 @@ protected DeleteScriptDescriptor(): base()
// values part of the url path
Id IDeleteScriptRequest.Id => Self.RouteValues.Get<Id>("id");
// Request parameters
///<summary>Specify timeout for connection tomaster node</summary>
///<summary>Specify timeout for connection to master node</summary>
///<remarks>Deprecated as of OpenSearch 2.0, use <see cref="ClusterManagerTimeout"/> instead</remarks>
public DeleteScriptDescriptor MasterTimeout(Time mastertimeout) => Qs("master_timeout", mastertimeout);
///<summary>Specify timeout for connection tocluster_manager node</summary>
///<summary>Specify timeout for connection to cluster_manager node</summary>
///<remarks>Introduced in OpenSearch 2.0 instead of <see cref="MasterTimeout"/></remarks>
public DeleteScriptDescriptor ClusterManagerTimeout(Time timeout) => Qs("cluster_manager_timeout", timeout);
///<summary>Explicit operation timeout</summary>
Expand Down Expand Up @@ -785,10 +785,10 @@ protected GetScriptDescriptor(): base()
// values part of the url path
Id IGetScriptRequest.Id => Self.RouteValues.Get<Id>("id");
// Request parameters
///<summary>Specify timeout for connection tomaster node</summary>
///<summary>Specify timeout for connection to master node</summary>
///<remarks>Deprecated as of OpenSearch 2.0, use <see cref="ClusterManagerTimeout"/> instead</remarks>
public GetScriptDescriptor MasterTimeout(Time mastertimeout) => Qs("master_timeout", mastertimeout);
///<summary>Specify timeout for connection tocluster_manager node</summary>
///<summary>Specify timeout for connection to cluster_manager node</summary>
///<remarks>Introduced in OpenSearch 2.0 instead of <see cref="MasterTimeout"/></remarks>
public GetScriptDescriptor ClusterManagerTimeout(Time timeout) => Qs("cluster_manager_timeout", timeout);
}
Expand Down Expand Up @@ -1162,10 +1162,10 @@ protected PutScriptDescriptor(): base()
///<summary>Script context</summary>
public PutScriptDescriptor Context(Name context) => Assign(context, (a, v) => a.RouteValues.Optional("context", v));
// Request parameters
///<summary>Specify timeout for connection tomaster node</summary>
///<summary>Specify timeout for connection to master node</summary>
///<remarks>Deprecated as of OpenSearch 2.0, use <see cref="ClusterManagerTimeout"/> instead</remarks>
public PutScriptDescriptor MasterTimeout(Time mastertimeout) => Qs("master_timeout", mastertimeout);
///<summary>Specify timeout for connection tocluster_manager node</summary>
///<summary>Specify timeout for connection to cluster_manager node</summary>
///<remarks>Introduced in OpenSearch 2.0 instead of <see cref="MasterTimeout"/></remarks>
public PutScriptDescriptor ClusterManagerTimeout(Time timeout) => Qs("cluster_manager_timeout", timeout);
///<summary>Explicit operation timeout</summary>
Expand Down
2 changes: 1 addition & 1 deletion src/OpenSearch.Net.VirtualizedCluster/README.md
Original file line number Diff line number Diff line change
@@ -1 +1 @@
A utility used by unit tests of `OpenSearch.Net` and `OpenSearch.Client`. It allows to create a fake virtual OpenSearch cluster to test and debug REST API calls.
A library used by unit tests of `OpenSearch.Net` and `OpenSearch.Client`. It allows to create a fake virtual OpenSearch cluster to test and debug REST API calls.

0 comments on commit 571669b

Please sign in to comment.