Allow setting TrackTotalHits to both boolean and integer values #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Xtansia
requested review from
anirudha,
dblock,
joshuali925,
VachaShah,
MaxKsyunz and
Yury-Fridlyand
as code owners
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Yury-Fridlyand
previously approved these changes
Nov 25, 2022
A quick grep of the API docs suggests |
VachaShah
previously approved these changes
Jan 30, 2023
Xtansia
dismissed stale reviews from VachaShah and Yury-Fridlyand
via
5ec17e7
Yury-Fridlyand
approved these changes
Jan 30, 2023
|
Union types in .NET was an interesting read: dotnet/csharplang#399 |
dblock
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow setting TrackTotalHits to both boolean and integer values.
Issues Resolved
Fixes #119
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.