-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing of DateHistogramBucket key #131
Fix parsing of DateHistogramBucket key #131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you like adding query from #130 as a test?
@Yury-Fridlyand Sure, would you rather a full integration test, or just unit testing the deserialization using a mocked client & fixed response? |
I see IT is better and easier to add. |
f9be0c0
to
eb8b346
Compare
@Xtansia, perhaps you've lost the fix. |
eb8b346
to
0c42dc2
Compare
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
0c42dc2
to
916e503
Compare
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
@Yury-Fridlyand Was intentional as I was trying to get the reproduce working correctly, have got the reproduce and fix properly pushed now |
Description
Fixes the parsing of DateHistogramBuckets. The key was incorrectly being read as a long, when it should be a double. As can be seen here, the type parameter to
KeyedBucket
isdouble
: https://github.com/opensearch-project/opensearch-net/blob/main/src/OpenSearch.Client/Aggregations/Bucket/DateHistogram/DateHistogramBucket.cs#LL34C51-L34C51And response body from server looks like so:
Issues Resolved
Fixes #130
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.