Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the neural query type and text_embedding ingest processor type #636

Merged

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented May 7, 2024

Description

Adds support for the neural query type and the text_embedding ingest processor type

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Xtansia Xtansia force-pushed the feat/neural-search/implementation branch 28 times, most recently from a0a2799 to 66c91c3 Compare May 14, 2024 03:24
@Xtansia Xtansia marked this pull request as ready for review May 14, 2024 04:42
@Xtansia Xtansia requested a review from anirudha as a code owner May 14, 2024 04:42
@dblock
Copy link
Member

dblock commented May 14, 2024

@Xtansia Code looks ok to me, find someone who understands neural search to do a detailed CR?

@Xtansia Xtansia force-pushed the feat/neural-search/implementation branch from 66c91c3 to 69a9e43 Compare August 7, 2024 06:18
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
@Xtansia Xtansia force-pushed the feat/neural-search/implementation branch from 69a9e43 to 8cb3fbf Compare August 22, 2024 21:41
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the integration test!

@Xtansia Xtansia merged commit 9e7b819 into opensearch-project:main Aug 26, 2024
42 checks passed
@Xtansia Xtansia deleted the feat/neural-search/implementation branch August 26, 2024 02:03
@Xtansia Xtansia added the backport 1.x Backport to 1.x branch label Aug 26, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-636-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9e7b819082e222700499699f7c785fa14a3d526b
# Push it to GitHub
git push --set-upstream origin backport/backport-636-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-636-to-1.x.

Xtansia added a commit to Xtansia/opensearch-net that referenced this pull request Aug 26, 2024
… type (opensearch-project#636)

* Implement `text_embedding` ingest pipeline processor

Signed-off-by: Thomas Farr <tsfarr@amazon.com>

* Implement `neural` search query type

Signed-off-by: Thomas Farr <tsfarr@amazon.com>

* Add changelog entry and fix license headers

Signed-off-by: Thomas Farr <tsfarr@amazon.com>

* Improve test

Signed-off-by: Thomas Farr <tsfarr@amazon.com>

* Separate neural query cluster configuration

Signed-off-by: Thomas Farr <tsfarr@amazon.com>

---------

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
(cherry picked from commit 9e7b819)
dblock pushed a commit that referenced this pull request Aug 27, 2024
… type (#636) (#769)

* Implement `text_embedding` ingest pipeline processor

Signed-off-by: Thomas Farr <tsfarr@amazon.com>

* Implement `neural` search query type

Signed-off-by: Thomas Farr <tsfarr@amazon.com>

* Add changelog entry and fix license headers

Signed-off-by: Thomas Farr <tsfarr@amazon.com>

* Improve test

Signed-off-by: Thomas Farr <tsfarr@amazon.com>

* Separate neural query cluster configuration

Signed-off-by: Thomas Farr <tsfarr@amazon.com>

---------

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
(cherry picked from commit 9e7b819)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x Backport to 1.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants