-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the neural
query type and text_embedding
ingest processor type
#636
Support the neural
query type and text_embedding
ingest processor type
#636
Conversation
a0a2799
to
66c91c3
Compare
@Xtansia Code looks ok to me, find someone who understands neural search to do a detailed CR? |
66c91c3
to
69a9e43
Compare
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
69a9e43
to
8cb3fbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the integration test!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-636-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9e7b819082e222700499699f7c785fa14a3d526b
# Push it to GitHub
git push --set-upstream origin backport/backport-636-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
… type (opensearch-project#636) * Implement `text_embedding` ingest pipeline processor Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Implement `neural` search query type Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Add changelog entry and fix license headers Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Improve test Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Separate neural query cluster configuration Signed-off-by: Thomas Farr <tsfarr@amazon.com> --------- Signed-off-by: Thomas Farr <tsfarr@amazon.com> (cherry picked from commit 9e7b819)
… type (#636) (#769) * Implement `text_embedding` ingest pipeline processor Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Implement `neural` search query type Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Add changelog entry and fix license headers Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Improve test Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Separate neural query cluster configuration Signed-off-by: Thomas Farr <tsfarr@amazon.com> --------- Signed-off-by: Thomas Farr <tsfarr@amazon.com> (cherry picked from commit 9e7b819)
Description
Adds support for the
neural
query type and thetext_embedding
ingest processor typeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.