Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Indices.BulkAsync summary #717

Merged

Conversation

jumc
Copy link
Contributor

@jumc jumc commented Jul 17, 2024

Description

Update Indices.BulkAsync summary with the correct API name

Issues Resolved

Closes [#715].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@Xtansia Xtansia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this and making a PR, there's just a few other things to fix in the comments.

It looks like the DCO check (checks for Signed-off-by:) is failing as the Committer, Author and Signed-off-by details of the commit don't match, could you please look into amending them?
Screenshot 2024-07-18 at 11 05 49 AM

src/OpenSearch.Client/OpenSearchClient.Indices.cs Outdated Show resolved Hide resolved
src/OpenSearch.Client/OpenSearchClient.Indices.cs Outdated Show resolved Hide resolved
src/OpenSearch.Client/OpenSearchClient.Indices.cs Outdated Show resolved Hide resolved
src/OpenSearch.Client/OpenSearchClient.Indices.cs Outdated Show resolved Hide resolved
@jumc jumc force-pushed the fix/Indices.BulkAsync_documentation branch from 73afe11 to 9ec0081 Compare August 7, 2024 14:46
jumc and others added 5 commits August 7, 2024 11:47
Signed-off-by: Juliana M. Crivelli <ju_jumc@hotmail.com>
Co-authored-by: Thomas Farr <xtansia@xtansia.com>
Signed-off-by: Juliana M. Crivelli <ju_jumc@hotmail.com>
Co-authored-by: Thomas Farr <xtansia@xtansia.com>
Signed-off-by: Juliana M. Crivelli <ju_jumc@hotmail.com>
Co-authored-by: Thomas Farr <xtansia@xtansia.com>
Signed-off-by: Juliana M. Crivelli <ju_jumc@hotmail.com>
Co-authored-by: Thomas Farr <xtansia@xtansia.com>
Signed-off-by: Juliana M. Crivelli <ju_jumc@hotmail.com>
@Xtansia Xtansia merged commit c2fdd5d into opensearch-project:main Aug 7, 2024
38 of 42 checks passed
@Xtansia Xtansia added the backport 1.x Backport to 1.x branch label Aug 7, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-717-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c2fdd5d1df4929000249d07ccdf2c8b21fd2fde6
# Push it to GitHub
git push --set-upstream origin backport/backport-717-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-717-to-1.x.

Xtansia pushed a commit to Xtansia/opensearch-net that referenced this pull request Aug 7, 2024
* Fix Indices.BulkAsync summary

Signed-off-by: Juliana M. Crivelli <ju_jumc@hotmail.com>

* Update src/OpenSearch.Client/OpenSearchClient.Indices.cs

Co-authored-by: Thomas Farr <xtansia@xtansia.com>
Signed-off-by: Juliana M. Crivelli <ju_jumc@hotmail.com>

* Update src/OpenSearch.Client/OpenSearchClient.Indices.cs

Co-authored-by: Thomas Farr <xtansia@xtansia.com>
Signed-off-by: Juliana M. Crivelli <ju_jumc@hotmail.com>

* Update src/OpenSearch.Client/OpenSearchClient.Indices.cs

Co-authored-by: Thomas Farr <xtansia@xtansia.com>
Signed-off-by: Juliana M. Crivelli <ju_jumc@hotmail.com>

* Update src/OpenSearch.Client/OpenSearchClient.Indices.cs

Co-authored-by: Thomas Farr <xtansia@xtansia.com>
Signed-off-by: Juliana M. Crivelli <ju_jumc@hotmail.com>

---------

Signed-off-by: Juliana M. Crivelli <ju_jumc@hotmail.com>
Co-authored-by: Thomas Farr <xtansia@xtansia.com>
(cherry picked from commit c2fdd5d)
dblock pushed a commit that referenced this pull request Aug 8, 2024
* Fix Indices.BulkAsync summary

Signed-off-by: Juliana M. Crivelli <ju_jumc@hotmail.com>

* Update src/OpenSearch.Client/OpenSearchClient.Indices.cs

Co-authored-by: Thomas Farr <xtansia@xtansia.com>
Signed-off-by: Juliana M. Crivelli <ju_jumc@hotmail.com>

* Update src/OpenSearch.Client/OpenSearchClient.Indices.cs

Co-authored-by: Thomas Farr <xtansia@xtansia.com>
Signed-off-by: Juliana M. Crivelli <ju_jumc@hotmail.com>

* Update src/OpenSearch.Client/OpenSearchClient.Indices.cs

Co-authored-by: Thomas Farr <xtansia@xtansia.com>
Signed-off-by: Juliana M. Crivelli <ju_jumc@hotmail.com>

* Update src/OpenSearch.Client/OpenSearchClient.Indices.cs

Co-authored-by: Thomas Farr <xtansia@xtansia.com>
Signed-off-by: Juliana M. Crivelli <ju_jumc@hotmail.com>

---------

Signed-off-by: Juliana M. Crivelli <ju_jumc@hotmail.com>
Co-authored-by: Thomas Farr <xtansia@xtansia.com>
(cherry picked from commit c2fdd5d)

Co-authored-by: Juliana M. Crivelli <ju_jumc@hotmail.com>
@jumc jumc deleted the fix/Indices.BulkAsync_documentation branch August 8, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x Backport to 1.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants