Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated Ml Namespace Endpoints Using OpenSearch API Specifications #214

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

saimedhi
Copy link
Collaborator

@saimedhi saimedhi commented Jul 15, 2024

Description

  • Generated ML namespace endpoints using OpenSearch API specifications.
  • Differences to note:
    • Namespace name changed from 'MachineLearning' to 'Ml'.
    • Endpoints usage remains unchanged, as seen in tests here.
    • Endpoint proxy has been implemented for getModels. It now redirects to the searchModels endpoint. (Endpoint renamed)
    • Moved all endpoints in MachineLearning namespace to Ml namespace. Added proxy endpoints, when generated code differs from existing.

Issues Resolved

Closes #97

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>
@dblock
Copy link
Member

dblock commented Jul 15, 2024

So no changes for users, ie. it remains ->ml() as before? Just confirming.

@dblock dblock merged commit 11b123e into opensearch-project:main Jul 15, 2024
46 checks passed
@saimedhi
Copy link
Collaborator Author

saimedhi commented Jul 15, 2024

So no changes for users, ie. it remains ->ml() as before? Just confirming.

  • Yes, it remains ->ml(). The property used for both the previous MachineLearning namespace and the current Ml namespace is called ml. To the best of my knowledge, this ensures there are no breaking changes for users.

  • The call in the tests here is similar to the implementation outlined in the guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] New API Client generated from spec
2 participants