Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated opensearch-php to reflect the latest OpenSearch API spec #223

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updated opensearch-php to reflect the latest OpenSearch API spec #223

wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Aug 13, 2024 •
edited
Loading

Updated opensearch-php to reflect the latest OpenSearch API spec
Date: 2024-09-20

@opensearch-trigger-bot opensearch-trigger-bot bot force-pushed the automated-api-update branch 4 times, most recently from ba0e381 to da215d9 Compare August 20, 2024 03:35
@dblock
Copy link
Member

dblock commented Aug 20, 2024

I don't merge all of these to gather more of the API changes together, then merge all at once before a release.

@opensearch-trigger-bot opensearch-trigger-bot bot force-pushed the automated-api-update branch 5 times, most recently from 0fb3270 to 29fa8e1 Compare August 27, 2024 03:35
@dblock
Copy link
Member

dblock commented Aug 27, 2024

Some legit errors that need to be looked at from the generated code.

1) OpenSearch\Tests\Namespaces\MlNamespaceTest::testDeployModel
OpenSearch\Common\Exceptions\RuntimeException: Missing parameter for the endpoint ml.deploy_model

/Users/runner/work/opensearch-php/opensearch-php/src/OpenSearch/Endpoints/Ml/DeployModel.php:32
/Users/runner/work/opensearch-php/opensearch-php/src/OpenSearch/Namespaces/AbstractNamespace.php:63
/Users/runner/work/opensearch-php/opensearch-php/src/OpenSearch/Namespaces/MlNamespace.php:273
/Users/runner/work/opensearch-php/opensearch-php/tests/Namespaces/MachineLearningNamespaceTest.php:[32](https://github.com/opensearch-project/opensearch-php/actions/runs/10571259471/job/29287037384?pr=223#step:5:33)6

2) OpenSearch\Tests\Namespaces\MlNamespaceTest::testUnDeployModel
OpenSearch\Common\Exceptions\RuntimeException: Missing parameter for the endpoint ml.undeploy_model

/Users/runner/work/opensearch-php/opensearch-php/src/OpenSearch/Endpoints/Ml/UndeployModel.php:32
/Users/runner/work/opensearch-php/opensearch-php/src/OpenSearch/Namespaces/AbstractNamespace.php:63
/Users/runner/work/opensearch-php/opensearch-php/src/OpenSearch/Namespaces/MlNamespace.php:420
/Users/runner/work/opensearch-php/opensearch-php/tests/Namespaces/MachineLearningNamespaceTest.php:[34](https://github.com/opensearch-project/opensearch-php/actions/runs/10571259471/job/29287037384?pr=223#step:5:35)6

@opensearch-trigger-bot opensearch-trigger-bot bot force-pushed the automated-api-update branch 5 times, most recently from 78bc5ec to 80acb62 Compare September 4, 2024 03:35
@opensearch-trigger-bot opensearch-trigger-bot bot force-pushed the automated-api-update branch 5 times, most recently from 24b4a69 to a3d8c5d Compare September 11, 2024 03:35
@opensearch-trigger-bot opensearch-trigger-bot bot force-pushed the automated-api-update branch 3 times, most recently from 60d900c to aeaf862 Compare September 14, 2024 03:35
@opensearch-trigger-bot opensearch-trigger-bot bot force-pushed the automated-api-update branch 2 times, most recently from b70e662 to 2a4a99e Compare September 18, 2024 03:36
@dblock
Updated opensearch-php to reflect the latest OpenSearch API spec (202…
4bfae11 
…4-09-20)

Signed-off-by: GitHub <noreply@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@harshavamsi harshavamsi Awaiting requested review from harshavamsi harshavamsi is a code owner

@shyim shyim Awaiting requested review from shyim shyim is a code owner

@saimedhi saimedhi Awaiting requested review from saimedhi saimedhi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
autocut
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dblock