Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] Add automated license header check to all plugins #138

Open
1 task done
Tracked by #1818 ...
dblock opened this issue Apr 6, 2022 · 4 comments
Open
1 task done
Tracked by #1818 ...

[Meta] Add automated license header check to all plugins #138

dblock opened this issue Apr 6, 2022 · 4 comments
Labels
campaign Parent issues of OpenSearch release campaigns. enhancement New feature or request Meta

Comments

@dblock
Copy link
Member

dblock commented Apr 6, 2022

Is your feature request related to a problem?
Some obsolete ALv2 headers are still found in various plugins, e.g. here.

What solution would you like?

  1. Document an SOP of how to add automated license checks for both OpenSearch and OpenSearch Dashboards. One possible solution is to add automated license header Gradle checks to CI similar to this.
  2. Update the default header for all new files created by IDEs similar to [License] Update SPDX License Header OpenSearch#510.
  3. Fix any incorrect headers.

Do you have any additional context?
Licenses must match https://github.com/opensearch-project/opensearch-plugins/blob/main/HEADERS.md

@ohltyler
Copy link
Member

ohltyler commented Jan 5, 2023

It seems this has been punted since 2.1 - is there any progress on this campaign actually being enforced for 2.5 or 2.6? It seems misleading to not follow through on campaigns listed in the main release issues.

@dblock
Copy link
Member Author

dblock commented Jan 9, 2023

@ohltyler Looks like it's being just continuously pushed out, want to take it on?

@ohltyler
Copy link
Member

ohltyler commented Jan 9, 2023

@ohltyler Looks like it's being just continuously pushed out, want to take it on?

I don't have bandwidth for this unfortunately. I'm more questioning on how we can be more transparent with our releases since many of the listed campaigns in the release issues are continuously not getting done and should be called out.

@joshuarrrr
Copy link
Member

As a campaign, it would be helpful to create repo-specific issues we could track, or provide a step-by-step checklist for repo-owners to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
campaign Parent issues of OpenSearch release campaigns. enhancement New feature or request Meta
Projects
None yet
Development

No branches or pull requests

4 participants