Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add GH workflow which checks for license headers #883

Open
Yury-Fridlyand opened this issue Oct 4, 2022 · 3 comments
Open

[FEATURE] Add GH workflow which checks for license headers #883

Yury-Fridlyand opened this issue Oct 4, 2022 · 3 comments
Labels
infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.

Comments

@Yury-Fridlyand
Copy link
Collaborator

Is your feature request related to a problem?

Developers sometime forget to add a license header to new files. This is not detected automatically.

What solution would you like?

An automated GH workflow which will check this

What alternatives have you considered?

N/A

Do you have any additional context?

Copy implementation from another repos.

@Yury-Fridlyand Yury-Fridlyand added enhancement New feature or request infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. untriaged labels Oct 4, 2022
@dai-chen dai-chen added bug Something isn't working and removed enhancement New feature or request untriaged labels Oct 6, 2022
@dai-chen
Copy link
Collaborator

dai-chen commented Oct 6, 2022

I re-label this as a bug because I recall it was enforced before. Thanks!

@Yury-Fridlyand
Copy link
Collaborator Author

Required by opensearch-project/opensearch-plugins#138

@acarbonetto acarbonetto removed the bug Something isn't working label Jun 26, 2023
@acarbonetto
Copy link
Collaborator

Note: Some OpenSearch java files have different licence formats.

Files impacted

  • core/src/main/java/org/opensearch/sql/expression/aggregation/StdDevAggregator.java
  • core/src/main/java/org/opensearch/sql/expression/aggregation/VarianceAggregator.java
  • core/src/test/java/org/opensearch/sql/expression/aggregation/StdDevAggregatorTest.java
  • opensearch/src/main/java/org/opensearch/sql/opensearch/response/agg/CompositeAggregationParser.java
  • opensearch/src/main/java/org/opensearch/sql/opensearch/response/agg/FilterParser.java
  • opensearch/src/main/java/org/opensearch/sql/opensearch/response/agg/MetricParser.java
  • opensearch/src/main/java/org/opensearch/sql/opensearch/response/agg/MetricParserHelper.java
  • opensearch/src/main/java/org/opensearch/sql/opensearch/response/agg/NoBucketAggregationParser.java
  • opensearch/src/main/java/org/opensearch/sql/opensearch/response/agg/OpenSearchAggregationResponseParser.java
  • opensearch/src/main/java/org/opensearch/sql/opensearch/response/agg/SingleValueParser.java
  • opensearch/src/main/java/org/opensearch/sql/opensearch/response/agg/StatsParser.java
  • opensearch/src/main/java/org/opensearch/sql/opensearch/response/agg/Utils.java

Each should be investigated and fixed if possible.

@acarbonetto acarbonetto added bug Something isn't working and removed bug Something isn't working labels Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

No branches or pull requests

3 participants