Update maps meta name to match plugin name #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
junqiu-lei
requested review from
dblock,
saratvemulapalli,
tlfeng,
VachaShah and
ohltyler
as code owners
| @@ -9,6 +9,6 @@ | |||
| "reportsDashboards": "git@github.com:opensearch-project/dashboards-reports.git", | |||
| "observabilityDashboards": "git@github.com:opensearch-project/observability.git", | |||
| "ganttChartDashboards": "git@github.com:opensearch-project/dashboards-visualizations.git", | |||
| "dashboards-maps": "git@github.com:opensearch-project/dashboards-maps.git" | |||
| "customImportMapDashboards": "git@github.com:opensearch-project/dashboards-maps.git" | |||
There was a problem hiding this comment.
Sounds very codified, is this the name we choose for the product?
There was a problem hiding this comment.
The name customImportMapDashboards is not used for maps product, but from opensearch-project/dashboards-maps#99 requirement, it seems like we need change the meta name to match plugin name. cc @mnkugler
There was a problem hiding this comment.
Sure it really doesn't matter for meta but sounds like a really geeky name for the plugin.
saratvemulapalli
approved these changes
Jan 18, 2023
VachaShah
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Junqiu Lei junqiu@amazon.com
Description
Update maps meta name to match the plugin name
Issues Resolved
opensearch-project/dashboards-maps#99
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.