-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add convention for plugin location (relates to #13879) #233
add convention for plugin location (relates to #13879) #233
Conversation
Signed-off-by: Amitai Stern <123amitai@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few wording nitpicks, but overall I like it
Co-authored-by: Andrew Ross <andrross@amazon.com> Signed-off-by: amitai stern <123amitai@gmail.com>
Co-authored-by: Andrew Ross <andrross@amazon.com> Signed-off-by: amitai stern <123amitai@gmail.com>
Signed-off-by: Amitai Stern <123amitai@gmail.com>
Thanks @andrross :) |
awaiting a second reviewer: @dblock @VachaShah @andrross @saratvemulapalli |
oh sorry @andrross i didn't see you are not on the maintainer list for this repo. thanks for the review though. |
And here I thought you just really valued my opinion :) |
lol, that is NOT how I wished to come across. sarcasm aside (some have told me I am incapable of sarcasm), your opinion is very much valued! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some nitpicky comments, feel free to use/ignore/resolve.
Signed-off-by: Amitai Stern <123amitai@gmail.com>
need one other approval for this one 🙏 |
I pinged @VachaShah for #229. |
Description
adding convention for where plugin code should be
Issues Resolved
opensearch-project/OpenSearch#13879
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.