Actually skip node_id_or_metric.

Signed-off-by: dblock <dblock@amazon.com>
opensearch-project · Jul 18, 2024 · 5a5174b · 5a5174b
1 parent 46a572a
commit 5a5174b
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 10 deletions.
diff --git a/opensearchpy/_async/client/nodes.py b/opensearchpy/_async/client/nodes.py
@@ -91,7 +91,6 @@ async def info(
         self,
         node_id: Any = None,
         metric: Any = None,
-        node_id_or_metric: Any = None,
         params: Any = None,
         headers: Any = None,
     ) -> Any:
@@ -103,9 +102,6 @@ async def info(
             limit returned information.
         :arg metric: Limits the information returned to the specific
             metrics. Supports a comma-separated list, such as http,ingest.
-        :arg node_id_or_metric: Limits the information returned to a
-            list of node IDs or specific metrics. Supports a comma-separated list,
-            such as node1,node2 or http,ingest.
         :arg error_trace: Whether to include the stack trace of returned
             errors.
         :arg filter_path: Comma-separated list of filters used to reduce

diff --git a/opensearchpy/client/nodes.py b/opensearchpy/client/nodes.py
@@ -91,7 +91,6 @@ def info(
         self,
         node_id: Any = None,
         metric: Any = None,
-        node_id_or_metric: Any = None,
         params: Any = None,
         headers: Any = None,
     ) -> Any:
@@ -103,9 +102,6 @@ def info(
             limit returned information.
         :arg metric: Limits the information returned to the specific
             metrics. Supports a comma-separated list, such as http,ingest.
-        :arg node_id_or_metric: Limits the information returned to a
-            list of node IDs or specific metrics. Supports a comma-separated list,
-            such as node1,node2 or http,ingest.
         :arg error_trace: Whether to include the stack trace of returned
             errors.
         :arg filter_path: Comma-separated list of filters used to reduce

diff --git a/utils/generate_api.py b/utils/generate_api.py
@@ -74,7 +74,7 @@
 
 IGNORED_PARAM_REFS = [
     # https://github.com/opensearch-project/opensearch-api-specification/pull/416
-    "#/components/parameters/nodes.info::path.node_id_or_metric"
+    "#/components/parameters/nodes.info::path.node_id_or_metric",
 ]
 
 jinja_env = Environment(
@@ -591,7 +591,7 @@ def read_modules() -> Any:
             for param_ref in endpoint["parameters"]:
 
                 if param_ref["$ref"] in IGNORED_PARAM_REFS:
-                    pass
+                    continue
 
                 param_ref = param_ref["$ref"].split("/")[-1]
                 param = data["components"]["parameters"][param_ref]