[BUG] additional info missing from TransportError when using async #225
Assignees
Labels
bug
Something isn't working
Comments
|
Nice catch. Feel free to offer a PR. |
gg-kialo
added a commit
to gg-kialo/opensearch-py
that referenced
this issue
May 8, 2023
Passing the Content-Type to `_raise_errors` will cause the json body to be parsed and included in the `TransportError`. This matches the behaviour of the sync client. Fixes opensearch-project#225 Signed-off-by: Gordon Govan <gg@kialo.com>
dblock
pushed a commit
that referenced
this issue
May 9, 2023
Passing the Content-Type to `_raise_errors` will cause the json body to be parsed and included in the `TransportError`. This matches the behaviour of the sync client. Fixes #225 Signed-off-by: Gordon Govan <gg@kialo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the bug?
TransportErrors are missing the parsed json stored on theinfoproperty when using the library with async.The cause is the content type is not being passed to
_raise_errorsfrom the async code.See the difference between the sync code and the async code
How can one reproduce the bug?
Make bad requests (e.g. 400s) when using the async code.
What is the expected behavior?
TransportErrorsinfoproperty should contain a dict with the parsed response (as in non-async use of the library).What is your host/environment?
Linux + MacOs
Do you have any screenshots?
Links to code above.
Do you have any additional context?
This bug was introduced in 1.1.0 when the content-type header started to be inspected before parsing the json. 1cd15b0
The text was updated successfully, but these errors were encountered: