Added CHANGELOG and verifier workflow #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavamsi
requested review from
a team,
axeoman and
deztructor
as code owners
harshavamsi
force-pushed
the
feature/changelog
branch
2 times, most recently
from
9329ca1
to
a3afd2c
Compare
|
There's a discussion on whether issue templates should be duplicated in opensearch-project/opensearch-go#172 (comment), let's resolve that before committing copies of those all over the place? |
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
harshavamsi
force-pushed
the
feature/changelog
branch
from
a3afd2c
to
3f13e5d
Compare
harshavamsi
requested review from
VachaShah,
dblock and
Shephalimittal
as code owners
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
dblock
approved these changes
Oct 20, 2022
VachaShah
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harsha Vamsi Kalluri harshavamsi096@gmail.com
Description
Adds a new pull request template to ensure that making a changelog entry is a required item. Adds a changelog verifier to ensure that each commit has associated change in the changelog.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.