Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release workflows #240

Merged
merged 5 commits into from
Nov 28, 2022
Merged

Add release workflows #240

merged 5 commits into from
Nov 28, 2022

Conversation

gaiksaya
Copy link
Member

Description

This PR adds below things:

  • A GitHub action workflow that will be triggered when a tag is pushed to this repository. The workflow builds the product and creates a draft release with built artifacts attached as artifacts.tar.gz in the release.
  • A jenkins workflow that is triggered based on above draft release. The workflow looks for artifacts.tar.gz, downloads it and then signs it and publishes it to PyPi

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gaiksaya
Copy link
Member Author

Getting few things in place so please wait before merging. Please feel free to review till then.
Thanks!

@VachaShah
Copy link
Collaborator

Workflows are failing for certain python versions for the latest ubuntu-22.04. Related issue on actions/setup-python actions/setup-python#543

@gaiksaya
Copy link
Member Author

I specified the ubuntu-latest version explicitly in the above failing workflows. Looks like GH is changing its GH runners for ubuntu latest from 20 to 22.
Let me know if this works. For link-checker, once this PR is approved, I'll add the workflow so that, that workflow passes too.
Thanks!

dblock
dblock previously approved these changes Nov 23, 2022
View reviewed changes
dblock
dblock previously approved these changes Nov 23, 2022
View reviewed changes
dblock
dblock reviewed Nov 23, 2022
View reviewed changes
RELEASING.md Outdated
1. This draft release triggers the [jenkins release workflow](https://build.ci.opensearch.org/job/opensearch-py-release/) as a result of which opensearch-py client is released on [PyPi](https://pypi.org/project/opensearch-py/).
1. Once the above release workflow is successful, the drafted release on GitHub is published automatically.
1. Increment "version" in [_version.py](./opensearchpy/_version.py) to the next patch release, e.g. v2.1.1. See [example](https://github.com/opensearch-project/opensearch-py/pull/167)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a period ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added :)

@gaiksaya
Add release workflows
ebb04d0 
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@gaiksaya
Fix drafter
13a77cc 
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@gaiksaya
Fix jenkins workflow
72a440c 
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@gaiksaya
Add credentials
b9910e8 
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@gaiksaya
Fix jenkins lib version
a2738ba 
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@gaiksaya gaiksaya requested a review from dblock November 24, 2022 00:27
@gaiksaya
Copy link
Member Author

Everything is set up. Once this PR is merged, I'll be creating the webhooks that will trigger the release when a tag is pushed.
Please review.
Thanks!

@dblock
Copy link
Member

dblock commented Nov 28, 2022

@VachaShah Good with you?

@gaiksaya
Copy link
Member Author

@VachaShah Good with you?

I believe she is out till end of next month. Do you still want to wait till then or get reviewed by anyone else?

@harshavamsi harshavamsi merged commit e44c5f1 into opensearch-project:main Nov 28, 2022
@gaiksaya gaiksaya deleted the release-worklows branch November 28, 2022 22:30
@gaiksaya
Copy link
Member Author

Webhook is added now! This repo is set for automated release once a tag is pushed. Please engage @opensearch-project/engineering-effectiveness in case of any failures or help.
Thanks!

@VachaShah VachaShah mentioned this pull request Jan 25, 2023
Closed
@harshavamsi harshavamsi mentioned this pull request Jan 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

@harshavamsi harshavamsi harshavamsi approved these changes

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@axeoman axeoman Awaiting requested review from axeoman axeoman is a code owner

@deztructor deztructor Awaiting requested review from deztructor

@Shephalimittal Shephalimittal Awaiting requested review from Shephalimittal Shephalimittal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaiksaya @VachaShah @dblock @harshavamsi