Adding async support for AWSSigV4 #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
harshavamsi
requested review from
VachaShah,
dblock,
axeoman,
deztructor and
Shephalimittal
as code owners
dblock
requested changes
Dec 20, 2022
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
harshavamsi
force-pushed
the
feature/asyncsigv4
branch
from
8fed221
to
0ec369f
Compare
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
harshavamsi
force-pushed
the
feature/asyncsigv4
branch
from
1301319
to
4047445
Compare
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
@dblock this PR is ready for review now. I created a new test class for the async signer. We can add more tests to that namespace in the future. Tested this locally with an async client and it works as expected. |
dblock
approved these changes
Jan 2, 2023
|
I like it. If you have time, you could make an async version of https://github.com/dblock/opensearch-python-client-demo (Pipfile lets you use a relative path with |
|
Did this make it into 2.0.1? I think it didn't, so our CHANGELOG was incorrectly modified. I opened #273. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harsha Vamsi Kalluri harshavamsi096@gmail.com
Description
Adds support for Async Sigv4 to authenticate with AWS IAM.
Issues Resolved
Closes #131
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.