Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(single-test): add single test run capability #325

Closed

Conversation

elamirKad
Copy link

@elamirKad elamirKad commented Mar 16, 2023

Description

This PR adds the ability to run a single test from the test suite using the -k flag for pytest, making it easier for developers to test specific functionality during development.
Now it is possible to test a single test by running:
./.ci/run-tests true 1.3.0 name_of_the_test

Issues Resolved

Closes #317

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: elamirkad <elamirkad@gmail.com>
@saimedhi
Copy link
Collaborator

Hello @elamirKad, Please try to fix the failing Integration tests. And also add your change to CHANGELOG.md file.

@elamirKad elamirKad force-pushed the single-test-execution branch 4 times, most recently from 4e5ab54 to 6e4bd47 Compare March 18, 2023 19:00
@elamirKad
Copy link
Author

Hello @saimedhi, I believe I have fixed integration tests and made the necessary additions to the CHANGELOG.md file.

@saimedhi
Copy link
Collaborator

Hello @saimedhi, I believe I have fixed integration tests and made the necessary additions to the CHANGELOG.md file.

Thanks for the changes @elamirKad. I have one more suggestion, could you please merge your 3 commits into one commit.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice. Nitpick: the pytest docs for -k say "Run tests by keyword expressions". Should we call this TEST_KEYWORD?

Let's document this in https://github.com/opensearch-project/opensearch-py/blob/main/DEVELOPER_GUIDE.md

@harshavamsi
Copy link
Collaborator

@elamirKad want to finish this?

@saimedhi
Copy link
Collaborator

saimedhi commented Jun 2, 2023

Hello @elamirKad, Thank you for contributing to the opensearch-py repository. Would you like to finish this?

@saimedhi
Copy link
Collaborator

@elamirKad, Kindly complete the pull request. This will be very helpful for developers. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Ability to execute a single unit/integration test
4 participants