[CCI][BUG] Test support required for Python v3.9+ #336
Conversation
bl1nkker
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
deztructor and
Shephalimittal
as code owners
|
Thanks, needs |
bl1nkker
force-pushed
the
fix/tests-support
branch
from
7bf38cb
to
c95bb69
Compare
|
done 👍 |
|
Before I merge this, we have a list of Python versions in https://github.com/opensearch-project/opensearch-py/blob/main/.github/workflows/ci.yml#L42. Why do we have the same list here? What does this one do, and are we going to forget to add a version next time? I'd imagine we want to have a list of Python versions in GHA only, and every time we add a new version we also say "Added support for Python X.Y" in CHANGELOG. |
|
When I was working on another problem, I noticed this too. It was rather strange to see that the same lines of code for tests were repeated twice In any case, those versions specified in ci.yml are required for testing before deployment. While the versions that are in noxfile are needed for testing locally. In fact, this tests are only needed for development purposes. |
|
@bl1nkker Should we add a comment here to also update .yml for CI and vice-versa? |
|
yeah, sure |
…ents Signed-off-by: bl1nkker <nurovich14@gmail.com>
bl1nkker
force-pushed
the
fix/tests-support
branch
from
c95bb69
to
85dcb26
Compare
|
done👍 also changed changelog.md |
|
@dblock Should i resolve this conflict? Or is it better to wait for a mentor? |
|
You should always rebase/resolve conflicts in your PRs, and iterate to green until they are merged. |
|
yes, sorry for the delayed reply |
|
any idea why python 3.4-3.6 tests don't work? |
| python-version: ["2.7", "3.7", "3.8", "3.9", "3.10", "3.11"] | ||
| # Python versions used for testing. Any changes made here should also be reflected in the noxfile.py file. | ||
| python-version: | ||
| ["2.7", "3.4", "3.5", "3.6", "3.7", "3.8", "3.9", "3.10", "3.11"] |
There was a problem hiding this comment.
Version matrix can be kept the same. Python versions 3.5 and 3.6 need a specific os and hence are already included in line 47 and line 50 of this file.
Please check my latest comment on why the tests are failing. |
|
Hello, @bl1nkker. Please do not modify existing Python versions. It is sufficient to add versions 3.10 and 3.11 to the Nox file and the Github workflow. If you are unable to resolve merge conflicts, please close this PR and create a new PR with only the changes indicated. Thanks :) |
|
Hello @bl1nkker, please complete the pull request. |
Description
Python 3.9+ support has been added
Issues Resolved
#323
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.