Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced botocore with aiobotocore in SigV4 asyncsigner #419

Conversation

saimedhi
Copy link
Collaborator

Description

Replaced botocore with aiobotocore in SigV4 asyncsigner

Issues Resolved

Closes #410

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: saimedhi <saimedhi@amazon.com>
@saimedhi
Copy link
Collaborator Author

Please let me know if any additional test cases are needed?

@dacevedo12
Copy link

Please let me know if any additional test cases are needed?

the aiobotocore dependency needs to be declared.

It's not a drop-in replacement unfortunately. aiobotocore.auth does not exist

One would have to figure out how to use it with AioRequestSigner from aiobotocore

@saimedhi
Copy link
Collaborator Author

Please let me know if any additional test cases are needed?

the aiobotocore dependency needs to be declared.

It's not a drop-in replacement unfortunately. aiobotocore.auth does not exist

One would have to figure out how to use it with AioRequestSigner from aiobotocore

@dacevedo12 , Thank you letting me know. I referred wrong documentation before. I will close this PR for now. Please give it a try if you find some time. Thanks :)

@saimedhi saimedhi marked this pull request as draft June 22, 2023 19:01
@saimedhi saimedhi closed this Jun 26, 2023
@saimedhi saimedhi deleted the Replacing_botocore_with_aiobotocore branch October 4, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Blocking behavior in AWSV4SignerAsyncAuth
2 participants