Move security api from plugins to clients

[florianvazelle]

Description

I move the SecurityClient from the plugins directory to the clients directory, accordingly to the @saimedhi comment (#399 (comment)).

All the security features are considered as part of core features of OS.

[codecov]

Codecov Report

Merging #442 (763b89d) into main (4dba35d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #442   +/-   ##
=======================================
  Coverage   71.49%   71.49%           
=======================================
  Files          81       81           
  Lines        7668     7668           
=======================================
  Hits         5482     5482           
  Misses       2186     2186           

Impacted Files	Coverage Δ
opensearchpy/_async/client/plugins.py	93.75% <ø> (-0.70%)	⬇️
opensearchpy/_async/client/security.py	51.08% <ø> (ø)
opensearchpy/client/plugins.py	93.75% <ø> (-0.70%)	⬇️
opensearchpy/client/security.py	51.08% <ø> (ø)
opensearchpy/_async/client/__init__.py	43.95% <100.00%> (+0.41%)	⬆️
opensearchpy/client/__init__.py	60.43% <100.00%> (+0.29%)	⬆️

[dblock]

How does this impact end-users? Anything I'd have to change in my code when upgrading?

[florianvazelle]

@dblock This not impact end-users, security API is still accessible from the client, I haven't changed the tests, it still works as before.
You'll just have to change the import paths if you imported the client directly from plugins (from opensearchpy.plugins import security into from opensearchpy.clients import security).

[dblock]

You'll just have to change the import paths if you imported the client directly from plugins (from opensearchpy.plugins import security into from opensearchpy.clients import security).

That's a breaking change :( Is there a way to proxy the old to the new so we don't have to bump the major version?

[saimedhi]

You'll just have to change the import paths if you imported the client directly from plugins (from opensearchpy.plugins import security into from opensearchpy.clients import security).

That's a breaking change :( Is there a way to proxy the old to the new so we don't have to bump the major version?

@dblock This change is not yet released.

[dblock]

You'll just have to change the import paths if you imported the client directly from plugins (from opensearchpy.plugins import security into from opensearchpy.clients import security).

That's a breaking change :( Is there a way to proxy the old to the new so we don't have to bump the major version?

@dblock This change is not yet released.

Oh! Good.