[CCI][GUIDE] Minor fixes to poetry docs #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raman Saparkhan <romasaparhan19@gmail.com>
roma2023
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
deztructor,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
Codecov Report
@@ Coverage Diff @@
## main #494 +/- ##
=======================================
Coverage 70.92% 70.92%
=======================================
Files 81 81
Lines 7732 7732
=======================================
Hits 5484 5484
Misses 2248 2248 |
saimedhi
previously approved these changes
Sep 14, 2023
Signed-off-by: Raman Saparkhan <romasaparhan19@gmail.com>
|
@roma2023, Issue is not specific to windows. I experienced it in Mac when running security/roles or security/users samples. |
|
@saimedhi Then, I believe the issue was more about the run command rather than the machine it was being run. |
Signed-off-by: Raman Saparkhan <romasaparhan19@gmail.com>
|
Change it to ready for review after you are done updating. Thank you :) |
Signed-off-by: Raman Saparkhan <romasaparhan19@gmail.com>
dblock
approved these changes
Sep 15, 2023
roma2023
added a commit
to roma2023/opensearch-py
that referenced
this pull request
Dec 28, 2023
* minor fixes to poetry docs Signed-off-by: Raman Saparkhan <romasaparhan19@gmail.com> * updated CHANGELOG.md Signed-off-by: Raman Saparkhan <romasaparhan19@gmail.com> * updated CHANGELOG.md Signed-off-by: Raman Saparkhan <romasaparhan19@gmail.com> * fixed CHANGELOG.md Signed-off-by: Raman Saparkhan <romasaparhan19@gmail.com> --------- Signed-off-by: Raman Saparkhan <romasaparhan19@gmail.com> Signed-off-by: roma2023 <romasaparhan19@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
pythonto run command of poetry. Now it runs aspoetry run python hello/hello.py.Issues Resolved
Issue #493 resolved.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.