Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated generated tasks client APIs into the existing module #508

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

saimedhi
Copy link
Collaborator

Description

  • Integrated generated tasks client APIs into the existing module, ensuring alignment with the server and maintaining backward compatibility.
  • The experimental APIs warning is not generated, and if necessary, I can include it using overrides. However, it's worth noting that the documentation no longer references these APIs as experimental."

Issues Resolved

Related to #477

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #508 (5c8a677) into main (69750e8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #508   +/-   ##
=======================================
  Coverage   70.92%   70.92%           
=======================================
  Files          81       81           
  Lines        7732     7732           
=======================================
  Hits         5484     5484           
  Misses       2248     2248           
Files Changed Coverage Δ
opensearchpy/_async/client/tasks.py 64.28% <ø> (ø)
opensearchpy/client/tasks.py 85.71% <ø> (ø)

…t with the server and maintaining backward compatibility

Signed-off-by: saimedhi <saimedhi@amazon.com>
@saimedhi
Copy link
Collaborator Author

Hi @florianvazelle, would you mind taking a moment to review this PR when you have a chance? Thank you!

@dblock dblock merged commit 2feccc2 into opensearch-project:main Sep 26, 2023
50 checks passed
AkshathRaghav pushed a commit to AkshathRaghav/opensearch-py that referenced this pull request Sep 29, 2023
…t with the server and maintaining backward compatibility (opensearch-project#508)

Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: AkshathRaghav <akshathraghav.r@gmail.com>
@saimedhi saimedhi deleted the merge/tasks_client branch October 4, 2023 22:17
roma2023 pushed a commit to roma2023/opensearch-py that referenced this pull request Dec 28, 2023
…t with the server and maintaining backward compatibility (opensearch-project#508)

Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: roma2023 <romasaparhan19@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants