Integrated generated "ingest" client APIs into the existing module #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saimedhi
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
deztructor,
Shephalimittal and
florianvazelle
as code owners
saimedhi
force-pushed
the
merge/ingest_client
branch
from
423362e
to
3eb8748
Compare
Codecov Report
@@ Coverage Diff @@
## main #513 +/- ##
=======================================
Coverage 70.86% 70.87%
=======================================
Files 83 83
Lines 7796 7790 -6
=======================================
- Hits 5525 5521 -4
+ Misses 2271 2269 -2
|
dblock
previously approved these changes
Sep 28, 2023
| from .utils import SKIP_IN_PATH, NamespacedClient, _make_path, query_params | ||
|
|
||
|
|
||
| class IngestClient(NamespacedClient): | ||
| @query_params("master_timeout", "cluster_manager_timeout", "summary") | ||
| @query_params("cluster_manager_timeout", "master_timeout") |
There was a problem hiding this comment.
yes. #513 (comment)
VachaShah
reviewed
Sep 28, 2023
opensearchpy/_async/client/ingest.py
Outdated
| :arg timeout: Explicit operation timeout | ||
| :arg cluster_manager_timeout: Operation timeout for connection | ||
| to cluster-manager node. | ||
| :arg master_timeout: Operation timeout for connection to master |
There was a problem hiding this comment.
May be we could keep the comments for master_timeout that it is deprecated?
There was a problem hiding this comment.
@VachaShah, Do you mean include deprecation msg in the param description using generator.
something like
:arg master_timeout (Deprecated: deprecation message from here ): Explicit operation timeout for connection
to master node
There was a problem hiding this comment.
Yeah! It would be nice to have it in the description of the param.
saimedhi
force-pushed
the
merge/ingest_client
branch
from
3eb8748
to
07db4ae
Compare
…uring alignment with the server and maintaining backward compatibility Signed-off-by: saimedhi <saimedhi@amazon.com>
saimedhi
force-pushed
the
merge/ingest_client
branch
from
07db4ae
to
8945885
Compare
VachaShah
approved these changes
Sep 29, 2023
roma2023
pushed a commit
to roma2023/opensearch-py
that referenced
this pull request
Dec 28, 2023
…uring alignment with the server and maintaining backward compatibility (opensearch-project#513) Signed-off-by: saimedhi <saimedhi@amazon.com> Signed-off-by: roma2023 <romasaparhan19@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrated generated ingest client APIs into the existing module, ensuring alignment with the server and maintaining backward compatibility
Issues Resolved
Related to #477
Testing the "summary" parameter in the "get_pipeline" API resulted in an error indicating that the parameter is unrecognized (Implies generated "get_pipeline" is correct)
{
"acknowledged": true
}
get https://localhost:9200/_ingest/pipeline/pipelineid123?summary=true{
"error": {
"root_cause": [
{
"type": "illegal_argument_exception",
"reason": "request [/_ingest/pipeline/pipelineid123] contains unrecognized parameter: [summary]"
}
],
"type": "illegal_argument_exception",
"reason": "request [/_ingest/pipeline/pipelineid123] contains unrecognized parameter: [summary]"
},
"status": 400
}
Ingest.geo_ip_stats should be removed from client(Generator is correct)
client.ingest.geo_ip_stats()RequestError: RequestError(400, 'no handler found for uri [/_ingest/geoip/stats] and method [GET]', 'no handler found for uri [/_ingest/geoip/stats] and method [GET]')
Before giving your approval, kindly double-check.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.