Modified generator to generate default value for parameters in description #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saimedhi
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
deztructor,
Shephalimittal and
florianvazelle
as code owners
Codecov Report
@@ Coverage Diff @@
## main #519 +/- ##
=======================================
Coverage 70.87% 70.87%
=======================================
Files 83 83
Lines 7790 7790
=======================================
Hits 5521 5521
Misses 2269 2269 |
saimedhi
force-pushed
the
add_default_paramvalue_to_gen
branch
from
a84e977
to
515edc4
Compare
…meters in description Signed-off-by: saimedhi <saimedhi@amazon.com>
saimedhi
force-pushed
the
add_default_paramvalue_to_gen
branch
from
7ec99e1
to
b4ea39f
Compare
|
I think we should have a code coverage goal that includes generated code. Try to come up with corresponding auto-generated tests? |
dblock
approved these changes
Oct 3, 2023
roma2023
pushed a commit
to roma2023/opensearch-py
that referenced
this pull request
Dec 28, 2023
…meters in description (opensearch-project#519) Signed-off-by: saimedhi <saimedhi@amazon.com> Signed-off-by: roma2023 <romasaparhan19@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modified generator to generate default value for parameters in description
Issues Resolved
Related to #477
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.