Expanded type coverage to benchmarks, samples and tests. #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #566 +/- ##
==========================================
- Coverage 71.69% 71.69% -0.01%
==========================================
Files 87 87
Lines 7875 7881 +6
==========================================
+ Hits 5646 5650 +4
- Misses 2229 2231 +2
|
dblock
force-pushed
the
rest-of-mypy
branch
2 times, most recently
from
361e3b2
to
e38d83e
Compare
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
dblock
requested review from
VachaShah,
harshavamsi,
axeoman,
deztructor,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
|
@saimedhi I think this is 🟢 |
|
@saimedhi good with you? (pls hit merge if yes) |
|
I think @saimedhi is OOO, will merge (please add more comments and I can take of them later if needed), thanks @VachaShah for a CR. |
roma2023
pushed a commit
to roma2023/opensearch-py
that referenced
this pull request
Dec 28, 2023
…project#566) * Renamed json samples to fix duplicate module name. Signed-off-by: dblock <dblock@amazon.com> * Enabled mypy on all source files. Signed-off-by: dblock <dblock@amazon.com> * Added missing types. Signed-off-by: dblock <dblock@amazon.com> * Added CHANGELOG. Signed-off-by: dblock <dblock@amazon.com> * Move type: ignore to fix untyped decorator makes function untyped. Signed-off-by: dblock <dblock@amazon.com> * Fix nox -rs lint-3.7. Signed-off-by: dblock <dblock@amazon.com> * Fixed incorrect import. Signed-off-by: dblock <dblock@amazon.com> * Fix broken test. Signed-off-by: dblock <dblock@amazon.com> * Fixed TestBulk::test_bulk_works_with_bytestring_body. Signed-off-by: dblock <dblock@amazon.com> --------- Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: roma2023 <romasaparhan19@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expanded type coverage to benchmarks, samples and tests.
Issues Resolved
Closes #564.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.