Fix: avoid decoding body unless it needs to be logged. #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested review from
VachaShah,
harshavamsi,
axeoman,
deztructor,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
dblock
force-pushed
the
avoid-body-decode
branch
from
49d4c13
to
69a23f7
Compare
Codecov Report
@@ Coverage Diff @@
## main #571 +/- ##
==========================================
+ Coverage 71.64% 71.74% +0.10%
==========================================
Files 87 87
Lines 7886 7886
==========================================
+ Hits 5650 5658 +8
+ Misses 2236 2228 -8
|
Signed-off-by: dblock <dblock@amazon.com>
dblock
force-pushed
the
avoid-body-decode
branch
from
69a23f7
to
6e5bd2c
Compare
Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
VachaShah
approved these changes
Nov 12, 2023
roma2023
pushed a commit
to roma2023/opensearch-py
that referenced
this pull request
Dec 28, 2023
…-project#571) Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com> Signed-off-by: roma2023 <romasaparhan19@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid calling
body.decode()unless we explicitly want the body to be logged.Issues Resolved
Closes #485.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.