Updated the get_policy API in the index_management plugin #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saimedhi
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
Shephalimittal and
florianvazelle
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #633 +/- ##
==========================================
+ Coverage 72.12% 72.14% +0.02%
==========================================
Files 89 89
Lines 7939 7935 -4
==========================================
- Hits 5726 5725 -1
+ Misses 2213 2210 -3 ☔ View full report in Codecov by Sentry. |
…e policy_id argument as optional Signed-off-by: saimedhi <saimedhi@amazon.com>
saimedhi
force-pushed
the
fix/ism_get_policy
branch
from
b810382
to
783869d
Compare
|
Can we add a test for this? |
dblock
approved these changes
Jan 10, 2024
Yes @VachaShah, we need specifications and a few modifications to the generator to generate plugins in the plugins folder. |
VachaShah
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the
get_policyAPI in the index_management plugin to allow the policy_id argument as optionalIssues Resolved
Closes #629
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.