Incorporated API generation into CI workflow and fixed 'generate' nox session #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saimedhi
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
Shephalimittal and
florianvazelle
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
=======================================
Coverage 72.13% 72.13%
=======================================
Files 89 89
Lines 7945 7945
=======================================
Hits 5731 5731
Misses 2214 2214 ☔ View full report in Codecov by Sentry. |
… session Signed-off-by: saimedhi <saimedhi@amazon.com>
saimedhi
force-pushed
the
api_generator_ci
branch
from
475764a
to
83f0646
Compare
|
@VachaShah, can you please take a look at this PR. |
dblock
reviewed
Jan 24, 2024
| run: | | ||
| python3.7 -m pip install nox | ||
| - name: Run the api generator | ||
| run: nox -s generate |
There was a problem hiding this comment.
I think we also want to block the PR if there were changes, don't we? Can be done in a separate PR.
There was a problem hiding this comment.
I think we also want to block the PR if there were changes, don't we
-
We will add a daily cron job to update code if there are specification changes.
-
PRs shouldn't be blocked as long as the generator CI test passes, even if they include changes, daily cron job handles it.
dblock
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Incorporated API generation into CI workflow and fixed 'generate' nox session
Issues Resolved
Closes #618
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.