-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance generator to update changelog only if generated code differs from existing #684
Enhance generator to update changelog only if generated code differs from existing #684
Conversation
…from existing Signed-off-by: saimedhi <saimedhi@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #684 +/- ##
=======================================
Coverage 72.14% 72.14%
=======================================
Files 89 89
Lines 7945 7945
=======================================
Hits 5732 5732
Misses 2213 2213 ☔ View full report in Codecov by Sentry. |
…from existing Signed-off-by: saimedhi <saimedhi@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge, but this seems a little complicated.
Would it make things simpler to do the rm -rf
, generate the code into opensearchpy
, then look at git status
to see what has changed?
I'll give that approach a try. Just want to make sure files like .pycache won't cause any issues. |
Anything generated should be in |
Btw, I think it's not important what has changed. The workflow that runs this check could generate the code, then check whether anything has changed, and only if something has generate the changelog. Then try opening the PR which would do nothing if there were no changes. |
…from existing (opensearch-project#684) * Enhance generator to update changelog only if generated code differs from existing Signed-off-by: saimedhi <saimedhi@amazon.com> * Enhance generator to update changelog only if generated code differs from existing Signed-off-by: saimedhi <saimedhi@amazon.com> --------- Signed-off-by: saimedhi <saimedhi@amazon.com> Signed-off-by: AbitraryYu <nikkoyhc@gmail.com>
…from existing (opensearch-project#684) * Enhance generator to update changelog only if generated code differs from existing Signed-off-by: saimedhi <saimedhi@amazon.com> * Enhance generator to update changelog only if generated code differs from existing Signed-off-by: saimedhi <saimedhi@amazon.com> --------- Signed-off-by: saimedhi <saimedhi@amazon.com>
Description
Enhance generator to update changelog only if generated code differs from existing code.
Issues Resolved
#680 (comment)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.