Introduced service time metrics to OpenSearch-Py client. #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #716 +/- ##
==========================================
- Coverage 71.95% 71.91% -0.05%
==========================================
Files 91 94 +3
Lines 8001 8085 +84
==========================================
+ Hits 5757 5814 +57
- Misses 2244 2271 +27 ☔ View full report in Codecov by Sentry. |
Signed-off-by: saimedhi <saimedhi@amazon.com>
saimedhi
force-pushed
the
service_time_pr
branch
from
715828f
to
5247b67
Compare
|
The failing tests are not related to this PR but are caused by recent changes to the OpenSearch API Specification, which is now natively written in OpenAPI. The generator and developer guide will be fixed accordingly in an upcoming PR. |
saimedhi
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
Shephalimittal and
florianvazelle
as code owners
|
@VachaShah please take a look |
dblock
reviewed
Apr 6, 2024
Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>
|
Ready for review |
dblock
requested changes
Apr 13, 2024
Signed-off-by: saimedhi <saimedhi@amazon.com>
saimedhi
force-pushed
the
service_time_pr
branch
from
859e385
to
a625715
Compare
dblock
approved these changes
Apr 15, 2024
AbitraryYu
pushed a commit
to AbitraryYu/opensearch-py
that referenced
this pull request
Apr 22, 2024
…project#716) * Introduced service time metrics to opensearch-py client Signed-off-by: saimedhi <saimedhi@amazon.com> * Introduced service time metrics to opensearch-py client Signed-off-by: saimedhi <saimedhi@amazon.com> * Introduced service time metrics to opensearch-py client Signed-off-by: saimedhi <saimedhi@amazon.com> * Added service time metrics Signed-off-by: saimedhi <saimedhi@amazon.com> --------- Signed-off-by: saimedhi <saimedhi@amazon.com> Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com> Signed-off-by: AbitraryYu <nikkoyhc@gmail.com>
dblock
pushed a commit
to dblock/opensearch-py
that referenced
this pull request
Aug 15, 2024
…project#716) * Introduced service time metrics to opensearch-py client Signed-off-by: saimedhi <saimedhi@amazon.com> * Introduced service time metrics to opensearch-py client Signed-off-by: saimedhi <saimedhi@amazon.com> * Introduced service time metrics to opensearch-py client Signed-off-by: saimedhi <saimedhi@amazon.com> * Added service time metrics Signed-off-by: saimedhi <saimedhi@amazon.com> --------- Signed-off-by: saimedhi <saimedhi@amazon.com> Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduced service time metrics to OpenSearch-Py client.
Issues Resolved
#678
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.