Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated numpy.float_ and update NumPy/Pandas imports #762

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

saimedhi
Copy link
Collaborator

@saimedhi saimedhi commented Jun 17, 2024

Description

  • Removed the deprecated usage of numpy.float_.
  • Updated NumPy and Pandas import statements for compatibility with latest Python versions.

Issues Resolved

#761 (comment)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@saimedhi saimedhi changed the title Removed deprecated np.float_ and update NumPy/Pandas imports Removed deprecated numpy.float_ and update NumPy/Pandas imports Jun 17, 2024
Signed-off-by: saimedhi <saimedhi@amazon.com>
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this possibly breaking anyone?

@saimedhi
Copy link
Collaborator Author

Is this possibly breaking anyone?

No, From my understanding np.float_ is equivalent to np.float64.

Deprecation message also suggests to use np.float64 instead.
np.float_ was removed in the NumPy 2.0 release. Use np.float64 instead.

@saimedhi saimedhi merged commit 1739a98 into opensearch-project:main Jun 17, 2024
54 checks passed
dblock pushed a commit to dblock/opensearch-py that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants