Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated compatibility matrix to include latest OpenSearch versions #765

Merged

Conversation

saimedhi
Copy link
Collaborator

Description

Updated compatibility matrix to include latest OpenSearch versions

Issues Resolved

Related to #759

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: saimedhi <saimedhi@amazon.com>
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.66%. Comparing base (ba715b9) to head (35b8612).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #765      +/-   ##
==========================================
- Coverage   71.95%   70.66%   -1.29%     
==========================================
  Files          91      105      +14     
  Lines        8001     8656     +655     
==========================================
+ Hits         5757     6117     +360     
- Misses       2244     2539     +295     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock
Copy link
Member

dblock commented Jun 18, 2024

@saimedhi
Copy link
Collaborator Author

We're not actually testing 2.14, add that?

https://github.com/opensearch-project/opensearch-py/blob/main/.github/workflows/integration.yml#L12

@dblock, OpenSearch versions 2.12, 2.13, 2.14 are now included in integration tests see here.
Done in PR #631

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dblock
Copy link
Member

dblock commented Jun 18, 2024

It's really odd that codecov shows a 1% difference.

@dblock dblock merged commit b0ca0f8 into opensearch-project:main Jun 18, 2024
63 of 71 checks passed
dblock pushed a commit to dblock/opensearch-py that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips changelog verifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants