Fixed issue 769:Collapse not preserved when chaining a search instance #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vatsal <vatsal.v.anand@gmail.com>
imvtsl
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
Signed-off-by: vatsal <vatsal.v.anand@gmail.com>
Signed-off-by: vatsal <vatsal.v.anand@gmail.com>
Signed-off-by: vatsal <vatsal.v.anand@gmail.com>
|
@saimedhi |
saimedhi
previously approved these changes
Jul 9, 2024
CHANGELOG.md
Outdated
| @@ -8,6 +8,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| ### Deprecated | |||
| ### Removed | |||
| ### Fixed | |||
| - Fixed issue 769: Collapse not preserved when chaining a search instance ([#771](https://github.com/opensearch-project/opensearch-py/pull/771)) | |||
There was a problem hiding this comment.
@imvtsl, thank you for the contribution. Please change the changelog entry to something like: 'Fixed Search helper to ensure proper retention of the _collapse attribute in chained operations.' No need to mention the issue number.
There was a problem hiding this comment.
I made the change. Thank you!
I believe you will have to approve again. It dismissed review automatically as soon as I pushed the change.
Signed-off-by: vatsal <vatsal.v.anand@gmail.com>
saimedhi
approved these changes
Jul 9, 2024
dblock
pushed a commit
to dblock/opensearch-py
that referenced
this pull request
Aug 15, 2024
opensearch-project#771) * Fixed issue 769:Collapse not preserved when chaining a search instance Signed-off-by: vatsal <vatsal.v.anand@gmail.com> * Fixed issue 769:Collapse not preserved when chaining a search instance Signed-off-by: vatsal <vatsal.v.anand@gmail.com> * Fixed issue 769:Collapse not preserved when chaining a search instance Signed-off-by: vatsal <vatsal.v.anand@gmail.com> * Fixed issue 769:Collapse not preserved when chaining a search instance Signed-off-by: vatsal <vatsal.v.anand@gmail.com> * Fixed issue 769:Collapse not preserved when chaining a search instance Signed-off-by: vatsal <vatsal.v.anand@gmail.com> --------- Signed-off-by: vatsal <vatsal.v.anand@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When clone method is called for search.filter(), collapse attribute was not copied. Therefore, collapse attribute wasn't getting chained to the search object. This fix adds copying the collapse attribute to the search object in the clone method.
Issues Resolved
Resolves #[769]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.