Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rc corrected to response #772

Merged
merged 2 commits into from
Jul 12, 2024
Merged

rc corrected to response #772

merged 2 commits into from
Jul 12, 2024

Conversation

oconpa
Copy link
Contributor

@oconpa oconpa commented Jul 9, 2024

There seems to be a mistype in the code. I believe it's meant to say response

Description

Describe what this change achieves.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

There seems to be a mistype in the code. I believe it's meant to say response

Signed-off-by: Patrick O'Connor <35761519+oconpa@users.noreply.github.com>
Copy link
Collaborator

@saimedhi saimedhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oconpa, thank you for your contribution! Could you please correct rc to response here as well? Thank you!

Signed-off-by: Patrick O'Connor <35761519+oconpa@users.noreply.github.com>
@oconpa
Copy link
Contributor Author

oconpa commented Jul 9, 2024

@oconpa, thank you for your contribution! Could you please correct rc to response here as well? Thank you!

Corrected good spot

@oconpa oconpa requested a review from saimedhi July 9, 2024 22:26
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.69%. Comparing base (ba715b9) to head (4a2c347).
Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #772      +/-   ##
==========================================
- Coverage   71.95%   70.69%   -1.26%     
==========================================
  Files          91      105      +14     
  Lines        8001     8657     +656     
==========================================
+ Hits         5757     6120     +363     
- Misses       2244     2537     +293     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saimedhi saimedhi merged commit 9ee0b23 into opensearch-project:main Jul 12, 2024
62 of 63 checks passed
dblock pushed a commit to dblock/opensearch-py that referenced this pull request Aug 15, 2024
* rc corrected to response

There seems to be a mistype in the code. I believe it's meant to say response

Signed-off-by: Patrick O'Connor <35761519+oconpa@users.noreply.github.com>

* Corrected line 33

Signed-off-by: Patrick O'Connor <35761519+oconpa@users.noreply.github.com>

---------

Signed-off-by: Patrick O'Connor <35761519+oconpa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips changelog verifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants