-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rc corrected to response #772
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be a mistype in the code. I believe it's meant to say response Signed-off-by: Patrick O'Connor <35761519+oconpa@users.noreply.github.com>
oconpa
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
July 9, 2024 20:08
saimedhi
requested changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Patrick O'Connor <35761519+oconpa@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #772 +/- ##
==========================================
- Coverage 71.95% 70.69% -1.26%
==========================================
Files 91 105 +14
Lines 8001 8657 +656
==========================================
+ Hits 5757 6120 +363
- Misses 2244 2537 +293 ☔ View full report in Codecov by Sentry. |
dblock
approved these changes
Jul 9, 2024
saimedhi
approved these changes
Jul 12, 2024
dblock
pushed a commit
to dblock/opensearch-py
that referenced
this pull request
Aug 15, 2024
* rc corrected to response There seems to be a mistype in the code. I believe it's meant to say response Signed-off-by: Patrick O'Connor <35761519+oconpa@users.noreply.github.com> * Corrected line 33 Signed-off-by: Patrick O'Connor <35761519+oconpa@users.noreply.github.com> --------- Signed-off-by: Patrick O'Connor <35761519+oconpa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a mistype in the code. I believe it's meant to say response
Description
Describe what this change achieves.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.