Skip put_aliases tests that don't require both index and alias parameters. #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested review from
VachaShah,
harshavamsi,
axeoman,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
…ters. Signed-off-by: dblock <dblock@amazon.com>
dblock
force-pushed
the
skip-put-aliases-tests
branch
from
fccc729
to
56b7b7c
Compare
saimedhi
approved these changes
Jul 18, 2024
dblock
added a commit
to dblock/opensearch-py
that referenced
this pull request
Aug 15, 2024
…ters. (opensearch-project#778) Signed-off-by: dblock <dblock@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes integration tests. The Python client alias functions require both an index and an alias as a parameter and don't try to be clever about it allowing a specification in the body. This is better user experience. Coming from #777, skips test variants that don't require both index and alias parameters. Similar to opensearch-project/opensearch-net#719.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.